You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/06/09 14:41:14 UTC
[GitHub] [fineract] danishjamal104 opened a new pull request #1764: Mustache template added to modify the generated code (FINERACT-1356)
danishjamal104 opened a new pull request #1764:
URL: https://github.com/apache/fineract/pull/1764
## Description
Since the generated sdk uses custom services and utils file, the `http-logging` library is missing in` pom.xml` which is used in `FineractClient.java`, also `Parts,java` uses `4.9.0` version of `okhttp3` library where as open api generator uses older version throwing an error in `RequestBody.create()` function since its older version is now deprecated, hence their are two major changes in generated `build.gradle` and `pom.xml`.
For default template file refer [build.gradle.mustache](https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/Java/libraries/retrofit2/build.gradle.mustache) and [pom.mustache](https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/Java/libraries/retrofit2/pom.mustache)
Ignore if these details are present on the associated [FINERACT-1356](https://issues.apache.org/jira/browse/FINERACT-1356).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [x] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] danishjamal104 commented on pull request #1764: Mustache template added to modify the generated code (FINERACT-1356)
Posted by GitBox <gi...@apache.org>.
danishjamal104 commented on pull request #1764:
URL: https://github.com/apache/fineract/pull/1764#issuecomment-939434762
Ill add comment in `build.gradle`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] danishjamal104 commented on pull request #1764: Mustache template added to modify the generated code (FINERACT-1356)
Posted by GitBox <gi...@apache.org>.
danishjamal104 commented on pull request #1764:
URL: https://github.com/apache/fineract/pull/1764#issuecomment-939483572
> Hi @danishjamal104 , could you please resolve the issues in travis CI build?
>
> ```
> 1 warning
> /home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/services/DocumentsApiFixed.java:36: error: duplicate class: org.apache.fineract.client.services.DocumentsApiFixed
> public interface DocumentsApiFixed {
> ^
> /home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/services/ImagesApi.java:37: error: duplicate class: org.apache.fineract.client.services.ImagesApi
> public interface ImagesApi {
> ^
> /home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/services/RunReportsApi.java:29: error: duplicate class: org.apache.fineract.client.services.RunReportsApi
> public interface RunReportsApi {
> ^
> /home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/util/FineractClient.java:151: error: duplicate class: org.apache.fineract.client.util.FineractClient
> public final class FineractClient {
> ^
> /home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/util/Calls.java:30: error: duplicate class: org.apache.fineract.client.util.Calls
> public final class Calls {
> ^
> /home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/util/JSON.java:48: error: duplicate class: org.apache.fineract.client.util.JSON
> class JSON {
> ^
> /home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/util/CallFailedRuntimeException.java:30: error: duplicate class: org.apache.fineract.client.util.CallFailedRuntimeException
> public class CallFailedRuntimeException extends RuntimeException {
> ^
> /home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/util/Parts.java:40: error: duplicate class: org.apache.fineract.client.util.Parts
> public final class Parts {
> ^
> /home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/auth/OAuthOkHttpClient.java:71: warning: [deprecation] create(MediaType,String) in RequestBody has been deprecated
> RequestBody body = request.getBody() != null ? RequestBody.create(mediaType, request.getBody()) : null;
> ^
> 8 errors
> 1 warning
> FAILURE: Build completed with 2 failures.
> 1: Task failed with an exception.
> -----------
> * What went wrong:
> Execution failed for task ':fineract-client:rat'.
> > A failure occurred while executing org.nosphere.apache.rat.RatWork
> > Apache Rat audit failure - 2 unapproved licenses
> See file:///home/travis/build/apache/fineract/fineract-client/build/reports/rat/index.html
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
> ==============================================================================
> 2: Task failed with an exception.
> -----------
> * What went wrong:
> Execution failed for task ':fineract-client:compileJava'.
> > Compilation failed; see the compiler error output for details.
> ```
done please merge now. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] danishjamal104 commented on pull request #1764: Mustache template added to modify the generated code (FINERACT-1356)
Posted by GitBox <gi...@apache.org>.
danishjamal104 commented on pull request #1764:
URL: https://github.com/apache/fineract/pull/1764#issuecomment-939434472
> Hi @danishjamal104 , could you please resolve the issues in travis CI build?
>
> ```
> 1 warning
> /home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/services/DocumentsApiFixed.java:36: error: duplicate class: org.apache.fineract.client.services.DocumentsApiFixed
> public interface DocumentsApiFixed {
> ^
> /home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/services/ImagesApi.java:37: error: duplicate class: org.apache.fineract.client.services.ImagesApi
> public interface ImagesApi {
> ^
> /home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/services/RunReportsApi.java:29: error: duplicate class: org.apache.fineract.client.services.RunReportsApi
> public interface RunReportsApi {
> ^
> /home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/util/FineractClient.java:151: error: duplicate class: org.apache.fineract.client.util.FineractClient
> public final class FineractClient {
> ^
> /home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/util/Calls.java:30: error: duplicate class: org.apache.fineract.client.util.Calls
> public final class Calls {
> ^
> /home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/util/JSON.java:48: error: duplicate class: org.apache.fineract.client.util.JSON
> class JSON {
> ^
> /home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/util/CallFailedRuntimeException.java:30: error: duplicate class: org.apache.fineract.client.util.CallFailedRuntimeException
> public class CallFailedRuntimeException extends RuntimeException {
> ^
> /home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/util/Parts.java:40: error: duplicate class: org.apache.fineract.client.util.Parts
> public final class Parts {
> ^
> /home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/auth/OAuthOkHttpClient.java:71: warning: [deprecation] create(MediaType,String) in RequestBody has been deprecated
> RequestBody body = request.getBody() != null ? RequestBody.create(mediaType, request.getBody()) : null;
> ^
> 8 errors
> 1 warning
> FAILURE: Build completed with 2 failures.
> 1: Task failed with an exception.
> -----------
> * What went wrong:
> Execution failed for task ':fineract-client:rat'.
> > A failure occurred while executing org.nosphere.apache.rat.RatWork
> > Apache Rat audit failure - 2 unapproved licenses
> See file:///home/travis/build/apache/fineract/fineract-client/build/reports/rat/index.html
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
> ==============================================================================
> 2: Task failed with an exception.
> -----------
> * What went wrong:
> Execution failed for task ':fineract-client:compileJava'.
> > Compilation failed; see the compiler error output for details.
> ```
I have fixed the 'RAT' error which was due to licensing issue. But the present error is unavoidable since it is due to duplicate class. Because fineract client generates the SDK in build folder and some replaceable files are automatically moved in their which also reside in src folder of fineract-client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] closed pull request #1764: Mustache template added to modify the generated code (FINERACT-1356)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1764:
URL: https://github.com/apache/fineract/pull/1764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola closed pull request #1764: Mustache template added to modify the generated code (FINERACT-1356)
Posted by GitBox <gi...@apache.org>.
ptuomola closed pull request #1764:
URL: https://github.com/apache/fineract/pull/1764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1764: Mustache template added to modify the generated code (FINERACT-1356)
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1764:
URL: https://github.com/apache/fineract/pull/1764#issuecomment-939409397
Hi @danishjamal104 , could you please resolve the issues in travis CI build?
```
1 warning
/home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/services/DocumentsApiFixed.java:36: error: duplicate class: org.apache.fineract.client.services.DocumentsApiFixed
public interface DocumentsApiFixed {
^
/home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/services/ImagesApi.java:37: error: duplicate class: org.apache.fineract.client.services.ImagesApi
public interface ImagesApi {
^
/home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/services/RunReportsApi.java:29: error: duplicate class: org.apache.fineract.client.services.RunReportsApi
public interface RunReportsApi {
^
/home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/util/FineractClient.java:151: error: duplicate class: org.apache.fineract.client.util.FineractClient
public final class FineractClient {
^
/home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/util/Calls.java:30: error: duplicate class: org.apache.fineract.client.util.Calls
public final class Calls {
^
/home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/util/JSON.java:48: error: duplicate class: org.apache.fineract.client.util.JSON
class JSON {
^
/home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/util/CallFailedRuntimeException.java:30: error: duplicate class: org.apache.fineract.client.util.CallFailedRuntimeException
public class CallFailedRuntimeException extends RuntimeException {
^
/home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/util/Parts.java:40: error: duplicate class: org.apache.fineract.client.util.Parts
public final class Parts {
^
/home/travis/build/apache/fineract/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/auth/OAuthOkHttpClient.java:71: warning: [deprecation] create(MediaType,String) in RequestBody has been deprecated
RequestBody body = request.getBody() != null ? RequestBody.create(mediaType, request.getBody()) : null;
^
8 errors
1 warning
FAILURE: Build completed with 2 failures.
1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':fineract-client:rat'.
> A failure occurred while executing org.nosphere.apache.rat.RatWork
> Apache Rat audit failure - 2 unapproved licenses
See file:///home/travis/build/apache/fineract/fineract-client/build/reports/rat/index.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
==============================================================================
2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':fineract-client:compileJava'.
> Compilation failed; see the compiler error output for details.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] danishjamal104 commented on pull request #1764: Mustache template added to modify the generated code (FINERACT-1356)
Posted by GitBox <gi...@apache.org>.
danishjamal104 commented on pull request #1764:
URL: https://github.com/apache/fineract/pull/1764#issuecomment-877919316
I am working on it.
Regards,
Danish Jamal
On Sat, 10 Jul 2021 at 05:36, github-actions[bot] ***@***.***>
wrote:
> This pull request seems to be stale. Are you still planning to work on it?
> We will automatically close it in 30 days.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/1764#issuecomment-877516954>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AHO5OWAKX6GVRKJE2L5OY23TW6FIVANCNFSM46MF6JFQ>
> .
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1764: Mustache template added to modify the generated code (FINERACT-1356)
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1764:
URL: https://github.com/apache/fineract/pull/1764#issuecomment-924044163
LGTM... need to check why the build is failing and fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola closed pull request #1764: Mustache template added to modify the generated code (FINERACT-1356)
Posted by GitBox <gi...@apache.org>.
ptuomola closed pull request #1764:
URL: https://github.com/apache/fineract/pull/1764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1764: Mustache template added to modify the generated code (FINERACT-1356)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1764:
URL: https://github.com/apache/fineract/pull/1764#issuecomment-898053786
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] danishjamal104 commented on pull request #1764: Mustache template added to modify the generated code (FINERACT-1356)
Posted by GitBox <gi...@apache.org>.
danishjamal104 commented on pull request #1764:
URL: https://github.com/apache/fineract/pull/1764#issuecomment-877919439
> This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
I have send a PR, waiting for reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] danishjamal104 closed pull request #1764: Mustache template added to modify the generated code (FINERACT-1356)
Posted by GitBox <gi...@apache.org>.
danishjamal104 closed pull request #1764:
URL: https://github.com/apache/fineract/pull/1764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] danishjamal104 removed a comment on pull request #1764: Mustache template added to modify the generated code (FINERACT-1356)
Posted by GitBox <gi...@apache.org>.
danishjamal104 removed a comment on pull request #1764:
URL: https://github.com/apache/fineract/pull/1764#issuecomment-877919316
I am working on it.
Regards,
Danish Jamal
On Sat, 10 Jul 2021 at 05:36, github-actions[bot] ***@***.***>
wrote:
> This pull request seems to be stale. Are you still planning to work on it?
> We will automatically close it in 30 days.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/1764#issuecomment-877516954>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AHO5OWAKX6GVRKJE2L5OY23TW6FIVANCNFSM46MF6JFQ>
> .
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1764: Mustache template added to modify the generated code (FINERACT-1356)
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1764:
URL: https://github.com/apache/fineract/pull/1764#issuecomment-939486548
@ptuomola Build is passing now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1764: Mustache template added to modify the generated code (FINERACT-1356)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1764:
URL: https://github.com/apache/fineract/pull/1764#issuecomment-877516954
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola merged pull request #1764: Mustache template added to modify the generated code (FINERACT-1356)
Posted by GitBox <gi...@apache.org>.
ptuomola merged pull request #1764:
URL: https://github.com/apache/fineract/pull/1764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org