[jira] Resolved: (WINK-316) AdminServlet doesn't process QueryParams properly

["Bryant Luk (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WINK-316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryant Luk resolved WINK-316.
-----------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.2
         Assignee: Bryant Luk

Patch looks good to me so I went ahead and applied it.  Thanks for the patch.  

> AdminServlet doesn't process QueryParams properly
> -------------------------------------------------
>
>                 Key: WINK-316
>                 URL: https://issues.apache.org/jira/browse/WINK-316
>             Project: Wink
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 1.1.1
>            Reporter: Ruby Boyarski
>            Assignee: Bryant Luk
>            Priority: Minor
>             Fix For: 1.1.2
>
>         Attachments: AdminServlet.java
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The AdminServlet doesn't include parameters of type QueryParam in its output.
> The reason is that the code to do that uses MatrixParam instead.
> The method buildQueryParams handles query params and instead of checking for QueryParam it's checking for MatrixParam (the problem is the "==injectable.ParamType.*MATRIX*").
> Here is the fixed method:
> {code}
> private void buildQueryParams(MethodMetadata methodMetadata, QueryParameters xmlQueryVariables) {
>         List<Injectable> formalParameters = methodMetadata.getFormalParameters();
>         for (Injectable var : formalParameters) {
>             if (var.getParamType() == Injectable.ParamType.QUERY) {
>                 Parameter param = resourcesObjectFactory.createParameter();
>                 param.setValue(((BoundInjectable)var).getName());
>                 xmlQueryVariables.getParameter().add(param);
>             }
>         }
>     }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.