You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2016/08/30 19:56:37 UTC
[Impala-ASF-CR] IMPALA-4019: initialize member variables in HdfsTableSink
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4171
Change subject: IMPALA-4019: initialize member variables in HdfsTableSink
......................................................................
IMPALA-4019: initialize member variables in HdfsTableSink
This fixes a bug that could potentially lead to the IMPALA-4019 crash.
default_partition_ should be initialized to NULL so that we can check
if the HdfsTableSink was correctly initialized with a default
partition in Open().
After this change the query will fail with an error status instead of
potentially crashing if table_desc_->partition_descriptors() is missing
the default partition.
Change-Id: If62def81f7d06b42ffbd0dc2dcb0e777421a1edf
---
M be/src/exec/hdfs-table-sink.cc
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/4171/1
--
To view, visit http://gerrit.cloudera.org:8080/4171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If62def81f7d06b42ffbd0dc2dcb0e777421a1edf
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-4019: initialize member variables in HdfsTableSink
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4019: initialize member variables in HdfsTableSink
......................................................................
Patch Set 1: Code-Review-2
I started a GVO. Marking -2 so it won't accidentally get merged.
--
To view, visit http://gerrit.cloudera.org:8080/4171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If62def81f7d06b42ffbd0dc2dcb0e777421a1edf
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4019: initialize member variables in HdfsTableSink
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4019: initialize member variables in HdfsTableSink
......................................................................
IMPALA-4019: initialize member variables in HdfsTableSink
This fixes a bug that could potentially lead to the IMPALA-4019 crash.
default_partition_ should be initialized to NULL so that we can check
if the HdfsTableSink was correctly initialized with a default
partition in Open().
After this change the query will fail with an error status instead of
potentially crashing if table_desc_->partition_descriptors() is missing
the default partition.
Change-Id: If62def81f7d06b42ffbd0dc2dcb0e777421a1edf
Reviewed-on: http://gerrit.cloudera.org:8080/4171
Reviewed-by: Alex Behm <al...@cloudera.com>
Reviewed-by: Dan Hecht <dh...@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/exec/hdfs-table-sink.cc
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Internal Jenkins: Verified
Alex Behm: Looks good to me, but someone else must approve
Dan Hecht: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/4171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If62def81f7d06b42ffbd0dc2dcb0e777421a1edf
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-4019: initialize member variables in HdfsTableSink
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4019: initialize member variables in HdfsTableSink
......................................................................
Patch Set 1: -Code-Review
--
To view, visit http://gerrit.cloudera.org:8080/4171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If62def81f7d06b42ffbd0dc2dcb0e777421a1edf
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4019: initialize member variables in HdfsTableSink
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4019: initialize member variables in HdfsTableSink
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If62def81f7d06b42ffbd0dc2dcb0e777421a1edf
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4019: initialize member variables in HdfsTableSink
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4019: initialize member variables in HdfsTableSink
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If62def81f7d06b42ffbd0dc2dcb0e777421a1edf
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4019: initialize member variables in HdfsTableSink
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-4019: initialize member variables in HdfsTableSink
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If62def81f7d06b42ffbd0dc2dcb0e777421a1edf
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-HasComments: No