[jira] [Commented] (AIRFLOW-5055) kubernetes_environment_variables section cannot be set using `AIRFLOW_` prefixed environment variables

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894164#comment-16894164 ] 

ASF GitHub Bot commented on AIRFLOW-5055:
-----------------------------------------

houqp commented on pull request #5668: [AIRFLOW-5055] support setting kubernetes_environment_variables config section from env var
URL: https://github.com/apache/airflow/pull/5668
 
 
   #5240 # Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   When `AIRFLOW_KUBERNETES_ENVIRONMENT_VARIABLES__AIRFLOW_HOME` is set in
   the scheduler, `AIRFLOW_HOME` should be set for workers, not airflow_home. This means `kubernetes_environment_variables` section's keys need to be parsed with case sensitivity.
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   Updated test in `test_env_var_config` to capture the requirement.
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> kubernetes_environment_variables section cannot be set using `AIRFLOW_` prefixed environment variables
> ------------------------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-5055
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5055
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: configuration
>    Affects Versions: 2.0.0
>            Reporter: QP Hou
>            Assignee: QP Hou
>            Priority: Minor
>
> When you set environment variables like `AIRFLOW__KUBERNETES_ENVIRONMENT_VARIABLES____AIRFLOW__HOME`, the scheduler will pass `airflow_home` as environment variable key to workers instead, which gets ignored by the workers.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)