You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "David Peterson (JIRA)" <ji...@apache.org> on 2008/02/04 08:55:09 UTC

[jira] Created: (WICKET-1317) web.xml context-param is non-unique

web.xml context-param is non-unique
-----------------------------------

                 Key: WICKET-1317
                 URL: https://issues.apache.org/jira/browse/WICKET-1317
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
    Affects Versions: 1.3.0-final
            Reporter: David Peterson
            Priority: Minor


I note tha the current web.xml configuration to push wicket into dev mode is:

<context-param>
  <param-name>configuration</param-name>
  <param-value>development</param-value>
</context-param>


Now shoot me down if you believe this to be a trivial objection, but I note that this wicket <param-name> string is very generic, and certainly cannot be guaranteed to be unique. It could easily collide with another component's "configuration" setting (though that would be an equally poorly named param-name).

May I suggest this be changed to:

<context-param>
  <param-name>wicket.configuration</param-name>
  <param-value>development</param-value>
</context-param>


I have tried to mark this issue "low key" as I don't want to ruffle feathers in my first wicket bug report ;)


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (WICKET-1317) web.xml context-param is non-unique

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg reassigned WICKET-1317:
-------------------------------------

    Assignee: Igor Vaynberg

> web.xml context-param is non-unique
> -----------------------------------
>
>                 Key: WICKET-1317
>                 URL: https://issues.apache.org/jira/browse/WICKET-1317
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.0-final
>            Reporter: David Peterson
>            Assignee: Igor Vaynberg
>            Priority: Minor
>             Fix For: 1.3.2
>
>
> I note tha the current web.xml configuration to push wicket into dev mode is:
> <context-param>
>   <param-name>configuration</param-name>
>   <param-value>development</param-value>
> </context-param>
> Now shoot me down if you believe this to be a trivial objection, but I note that this wicket <param-name> string is very generic, and certainly cannot be guaranteed to be unique. It could easily collide with another component's "configuration" setting (though that would be an equally poorly named param-name).
> May I suggest this be changed to:
> <context-param>
>   <param-name>wicket.configuration</param-name>
>   <param-value>development</param-value>
> </context-param>
> I have tried to mark this issue "low key" as I don't want to ruffle feathers in my first wicket bug report ;)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-1317) web.xml context-param is non-unique

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-1317.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3.2

> web.xml context-param is non-unique
> -----------------------------------
>
>                 Key: WICKET-1317
>                 URL: https://issues.apache.org/jira/browse/WICKET-1317
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.0-final
>            Reporter: David Peterson
>            Assignee: Igor Vaynberg
>            Priority: Minor
>             Fix For: 1.3.2
>
>
> I note tha the current web.xml configuration to push wicket into dev mode is:
> <context-param>
>   <param-name>configuration</param-name>
>   <param-value>development</param-value>
> </context-param>
> Now shoot me down if you believe this to be a trivial objection, but I note that this wicket <param-name> string is very generic, and certainly cannot be guaranteed to be unique. It could easily collide with another component's "configuration" setting (though that would be an equally poorly named param-name).
> May I suggest this be changed to:
> <context-param>
>   <param-name>wicket.configuration</param-name>
>   <param-value>development</param-value>
> </context-param>
> I have tried to mark this issue "low key" as I don't want to ruffle feathers in my first wicket bug report ;)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.