You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Dominik Drzewiecki (JIRA)" <ji...@apache.org> on 2009/02/10 09:46:59 UTC

[jira] Created: (WICKET-2094) Incorrect parameter name in SpringWebApplicationFactory's javadocs

Incorrect parameter name in SpringWebApplicationFactory's javadocs
------------------------------------------------------------------

                 Key: WICKET-2094
                 URL: https://issues.apache.org/jira/browse/WICKET-2094
             Project: Wicket
          Issue Type: Bug
          Components: wicket-spring
    Affects Versions: 1.4-RC2
            Reporter: Dominik Drzewiecki
            Priority: Minor
             Fix For: 1.4-RC3


The javadocs state that it is the parameter named "beanName" which value is taken into account when looking up spring managed application bean. It is wrong, according to the code it should say "applicationBean". Right now even if the wrong "beanName" parameter name is used applications tend to work because it is most common to use a single application class (bean in spring) and when the "applicationBean" init parameter is not provided, the factory falls back to the bean resolution based on the ancestor class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-2094) Incorrect parameter name in SpringWebApplicationFactory's javadocs

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-2094.
-----------------------------------

    Resolution: Fixed
      Assignee: Igor Vaynberg

> Incorrect parameter name in SpringWebApplicationFactory's javadocs
> ------------------------------------------------------------------
>
>                 Key: WICKET-2094
>                 URL: https://issues.apache.org/jira/browse/WICKET-2094
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-spring
>    Affects Versions: 1.4-RC2
>            Reporter: Dominik Drzewiecki
>            Assignee: Igor Vaynberg
>            Priority: Minor
>             Fix For: 1.4-RC3
>
>
> The javadocs state that it is the parameter named "beanName" which value is taken into account when looking up spring managed application bean. It is wrong, according to the code it should say "applicationBean". Right now even if the wrong "beanName" parameter name is used applications tend to work because it is most common to use a single application class (bean in spring) and when the "applicationBean" init parameter is not provided, the factory falls back to the bean resolution based on the ancestor class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.