You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Alexander zarei <al...@gmail.com> on 2014/09/08 23:37:38 UTC
Review Request 25454: DRILL-1297: C++ Client. Hide Dependencies From
Public API to enable using C++ Client as a DLL
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25454/
-----------------------------------------------------------
Review request for drill and Parth Chandra.
Repository: drill-git
Description
-------
DRILL-1297: C++ Client. Hide Dependencies From Public API to enable using C++ Client as a DLL
Diffs
-----
contrib/native/client/example/querySubmitter.cpp 17bec3c75f02b27c7d41d19d69b773d644c42831
contrib/native/client/readme.win.txt df6ee644353c442e032de8f388d96d145afc1a10
contrib/native/client/src/clientlib/drillClient.cpp a7aafaa06e286d854e39bad33d6ba0279b854801
contrib/native/client/src/clientlib/recordBatch.cpp 4c55f04827043fa263b1a3886ef3bacd16e935e3
contrib/native/client/src/include/drill/drillClient.hpp d03f88dad0fae6ba5f59884aa0c1641f9ee6c01f
contrib/native/client/src/include/drill/drillc.hpp 93a6b79d321d05e4f59e96c5f6592a4f6fafae67
contrib/native/client/src/include/drill/protobuf/User.pb.h
contrib/native/client/src/include/drill/recordBatch.hpp 61db88c8c5c4f088701dd63706307472a8300548
contrib/native/client/src/protobuf/CMakeLists.txt 1d0b3af1b09acbfea91d477c5ac357095d6d7f5c
Diff: https://reviews.apache.org/r/25454/diff/
Testing
-------
Thanks,
Alexander zarei
Re: Review Request 25454: DRILL-1297: C++ Client. Hide Dependencies
From Public API to enable using C++ Client as a DLL
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25454/#review53412
-----------------------------------------------------------
contrib/native/client/readme.win.txt
<https://reviews.apache.org/r/25454/#comment93063>
If you're ...
contrib/native/client/src/clientlib/recordBatch.cpp
<https://reviews.apache.org/r/25454/#comment93068>
Can you make the placement of the braces consistent with the rest of the file?
contrib/native/client/src/include/drill/drillClient.hpp
<https://reviews.apache.org/r/25454/#comment93065>
Should be "Types.pb.h". Names are case sensitive on non windows platforms.
Please check the build on Linux.
contrib/native/client/src/include/drill/drillClient.hpp
<https://reviews.apache.org/r/25454/#comment93069>
Can you fix the indentation to begin the enun declaration flush with the left margin (keeping it consistent with the rest of the file)
contrib/native/client/src/protobuf/CMakeLists.txt
<https://reviews.apache.org/r/25454/#comment93066>
Please fix indentation. (Spaces instead of tabs)
- Parth Chandra
On Sept. 8, 2014, 9:37 p.m., Alexander zarei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25454/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2014, 9:37 p.m.)
>
>
> Review request for drill and Parth Chandra.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-1297: C++ Client. Hide Dependencies From Public API to enable using C++ Client as a DLL
>
>
> Diffs
> -----
>
> contrib/native/client/example/querySubmitter.cpp 17bec3c75f02b27c7d41d19d69b773d644c42831
> contrib/native/client/readme.win.txt df6ee644353c442e032de8f388d96d145afc1a10
> contrib/native/client/src/clientlib/drillClient.cpp a7aafaa06e286d854e39bad33d6ba0279b854801
> contrib/native/client/src/clientlib/recordBatch.cpp 4c55f04827043fa263b1a3886ef3bacd16e935e3
> contrib/native/client/src/include/drill/drillClient.hpp d03f88dad0fae6ba5f59884aa0c1641f9ee6c01f
> contrib/native/client/src/include/drill/drillc.hpp 93a6b79d321d05e4f59e96c5f6592a4f6fafae67
> contrib/native/client/src/include/drill/protobuf/User.pb.h
> contrib/native/client/src/include/drill/recordBatch.hpp 61db88c8c5c4f088701dd63706307472a8300548
> contrib/native/client/src/protobuf/CMakeLists.txt 1d0b3af1b09acbfea91d477c5ac357095d6d7f5c
>
> Diff: https://reviews.apache.org/r/25454/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander zarei
>
>
Re: Review Request 25454: DRILL-1297: C++ Client. Hide Dependencies
From Public API to enable using C++ Client as a DLL
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25454/#review53538
-----------------------------------------------------------
One more thing needs to be done. The script DRILL/contrib/native/client/scripts/cpProtofiles.sh copies the User.pb.h file into the include/drill/protobuf directory. That needs to be changed to not copy the file anymore.
- Parth Chandra
On Sept. 8, 2014, 9:37 p.m., Alexander zarei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25454/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2014, 9:37 p.m.)
>
>
> Review request for drill and Parth Chandra.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-1297: C++ Client. Hide Dependencies From Public API to enable using C++ Client as a DLL
>
>
> Diffs
> -----
>
> contrib/native/client/example/querySubmitter.cpp 17bec3c75f02b27c7d41d19d69b773d644c42831
> contrib/native/client/readme.win.txt df6ee644353c442e032de8f388d96d145afc1a10
> contrib/native/client/src/clientlib/drillClient.cpp a7aafaa06e286d854e39bad33d6ba0279b854801
> contrib/native/client/src/clientlib/recordBatch.cpp 4c55f04827043fa263b1a3886ef3bacd16e935e3
> contrib/native/client/src/include/drill/drillClient.hpp d03f88dad0fae6ba5f59884aa0c1641f9ee6c01f
> contrib/native/client/src/include/drill/drillc.hpp 93a6b79d321d05e4f59e96c5f6592a4f6fafae67
> contrib/native/client/src/include/drill/protobuf/User.pb.h
> contrib/native/client/src/include/drill/recordBatch.hpp 61db88c8c5c4f088701dd63706307472a8300548
> contrib/native/client/src/protobuf/CMakeLists.txt 1d0b3af1b09acbfea91d477c5ac357095d6d7f5c
>
> Diff: https://reviews.apache.org/r/25454/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander zarei
>
>