You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/10 02:18:24 UTC
[GitHub] [spark] maropu commented on a change in pull request #28123:
[SPARK-31350][SQL] Coalesce bucketed tables for join if applicable
maropu commented on a change in pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable
URL: https://github.com/apache/spark/pull/28123#discussion_r406568219
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2574,6 +2574,17 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
+ val BUCKETING_COALESCE_ENABLED =
+ buildConf("spark.sql.bucketing.coalesce")
Review comment:
How about `spark.sql.bucketing.coalesce`->`....coalesceBucketInJoin`, `...coalesceJoinedBucket`, ... based on the naming rule? https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala#L41-L42
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org