You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by "BarbieQkiller (via GitHub)" <gi...@apache.org> on 2023/02/05 16:50:33 UTC
[GitHub] [sedona] BarbieQkiller opened a new pull request, #755: [SEDONA-179] Claim OGC compliance.
BarbieQkiller opened a new pull request, #755:
URL: https://github.com/apache/sedona/pull/755
## Did you read the Contributor Guide?
- Yes, I have read [Contributor Rules](https://sedona.apache.org/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/community/develop/)
## Is this PR related to a JIRA ticket?
- Yes, the URL of the assoicated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-179. The PR name follows the format `[SEDONA-179] my subject`.
## What changes were proposed in this PR?
The most relevant parts of OGC sfs tests for Geometry types and functions are implemented.
Findings: Two functions are not compliant plus some functions are not implemented in Sedona.
Tests for those are ignored with comments.
## How was this patch tested?
Test suite.
## Did this PR include necessary documentation updates?
- No, this PR does not affect any public API so no need to change the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [GitHub] [sedona] BarbieQkiller opened a new pull request, #755: [SEDONA-179] Claim OGC compliance.
Posted by Mo Sarwat <mo...@apache.org>.
This is a great PR!
Just wondering how the output of the test looks like. I will show all OGC
standard requirements and for each requirement a check mark ✅ is printed
out if Sedona supports it. On the other hand, if Sedona does not satisfy a
specific OGC requirement, the test will print out a cross mark ❌
Is that how it works?
Thanks,
-Mo
On Sun, Feb 5, 2023 at 9:51 AM BarbieQkiller (via GitHub) <gi...@apache.org>
wrote:
>
> BarbieQkiller opened a new pull request, #755:
> URL: https://github.com/apache/sedona/pull/755
>
>
> ## Did you read the Contributor Guide?
>
> - Yes, I have read [Contributor Rules](
> https://sedona.apache.org/community/rule/) and [Contributor Development
> Guide](https://sedona.apache.org/community/develop/)
>
> ## Is this PR related to a JIRA ticket?
>
> - Yes, the URL of the assoicated JIRA ticket is
> https://issues.apache.org/jira/browse/SEDONA-179. The PR name follows the
> format `[SEDONA-179] my subject`.
>
> ## What changes were proposed in this PR?
>
> The most relevant parts of OGC sfs tests for Geometry types and
> functions are implemented.
> Findings: Two functions are not compliant plus some functions are not
> implemented in Sedona.
> Tests for those are ignored with comments.
>
> ## How was this patch tested?
>
> Test suite.
>
> ## Did this PR include necessary documentation updates?
>
> - No, this PR does not affect any public API so no need to change the
> docs.
>
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
[GitHub] [sedona] jiayuasu commented on pull request #755: [SEDONA-179] Claim OGC compliance.
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on PR #755:
URL: https://github.com/apache/sedona/pull/755#issuecomment-1418683926
@BarbieQkiller Thanks for this great PR. I have updated SEDONA-179 to reflect the latest progress and I also created a number of tickets to fix these tests.
A few questions:
1. I didn't see Test 51 here. Is there a particular reason?
2. I didn't see PostGIS implements PolygonFromWKB for Test 9. Do you know how they handle this case?
Thanks,
Jia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sedona] BarbieQkiller commented on pull request #755: [SEDONA-179] Claim OGC compliance.
Posted by "BarbieQkiller (via GitHub)" <gi...@apache.org>.
BarbieQkiller commented on PR #755:
URL: https://github.com/apache/sedona/pull/755#issuecomment-1418902393
> @BarbieQkiller Thanks for this great PR. I have updated [SEDONA-179](https://issues.apache.org/jira/browse/SEDONA-179) to reflect the latest progress and I also created a number of tickets to fix these tests.
>
> A few questions:
>
> 1. I didn't see Test 51 here. Is there a particular reason?
> 2. I didn't see PostGIS implements PolygonFromWKB for Test 9. Do you know how they handle this case?
>
> Thanks, Jia
Thank you for your kind response!
1. I simply missed that one, apologies. I will update the PR.
2. T9 verifies ST_AsBinary the missing PolygonFromWKB shouldn't be a problem.
https://github.com/postgis/postgis/blob/f6def67654c25d812446239036cee44812613748/extras/ogc_test_suite/2_queries.sql#L255
Best regards
/Angela
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sedona] BarbieQkiller commented on pull request #755: [SEDONA-179] Claim OGC compliance.
Posted by "BarbieQkiller (via GitHub)" <gi...@apache.org>.
BarbieQkiller commented on PR #755:
URL: https://github.com/apache/sedona/pull/755#issuecomment-1419125944
Added the missing test.
BR,
/Angela
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sedona] jiayuasu merged pull request #755: [SEDONA-179] Claim OGC compliance
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #755:
URL: https://github.com/apache/sedona/pull/755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org