You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "tomsun28 (via GitHub)" <gi...@apache.org> on 2024/03/27 03:25:23 UTC

[PR] bugfix e2e test env prop actually not work [shenyu]

tomsun28 opened a new pull request, #5516:
URL: https://github.com/apache/shenyu/pull/5516

   <!-- Describe your PR here; e.g. Fixes #issueNo -->
   
   relate #5374 
   
   <!--
   Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
   -->
   Make sure that:
   
   - [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
   - [x] You submit test cases (unit or integration tests) that back your changes.
   - [x] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] bugfix e2e test env prop actually not work [shenyu]

Posted by "tomsun28 (via GitHub)" <gi...@apache.org>.
tomsun28 closed pull request #5516: bugfix e2e test env prop actually not work
URL: https://github.com/apache/shenyu/pull/5516


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] bugfix e2e test env prop actually not work [shenyu]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5516:
URL: https://github.com/apache/shenyu/pull/5516#issuecomment-2021866194

   ## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/5516?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 61.47%. Comparing base [(`d734418`)](https://app.codecov.io/gh/apache/shenyu/commit/d7344186034e54f1a6c0677f32808d868fb50b57?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`6dd2569`)](https://app.codecov.io/gh/apache/shenyu/pull/5516?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5516      +/-   ##
   ============================================
   - Coverage     61.58%   61.47%   -0.12%     
   + Complexity     8836     8828       -8     
   ============================================
     Files          1261     1261              
     Lines         39230    39229       -1     
     Branches       3723     3720       -3     
   ============================================
   - Hits          24161    24117      -44     
   - Misses        12897    12933      +36     
   - Partials       2172     2179       +7     
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/shenyu/pull/5516?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org