You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by sebb <se...@gmail.com> on 2013/05/23 02:53:33 UTC

Re: svn commit: r1485398 - /commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/findbugs-exclude-filter.xml

On 22 May 2013 21:19,  <gg...@apache.org> wrote:
> Author: ggregory
> Date: Wed May 22 20:19:00 2013
> New Revision: 1485398
>
> URL: http://svn.apache.org/r1485398
> Log:
> Remove rule that assumed DBCP 1.4 is on Java 1.4, it is on Java 6.
>

I'm not sure that's correct.
Although the code is designed for JDBC 4 (Java 1.6), it can also be
processed to generate code that supports JDBC 3 (Java 1.4/1.5)

> Modified:
>     commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/findbugs-exclude-filter.xml
>
> Modified: commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/findbugs-exclude-filter.xml
> URL: http://svn.apache.org/viewvc/commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/findbugs-exclude-filter.xml?rev=1485398&r1=1485397&r2=1485398&view=diff
> ==============================================================================
> --- commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/findbugs-exclude-filter.xml (original)
> +++ commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/findbugs-exclude-filter.xml Wed May 22 20:19:00 2013
> @@ -22,9 +22,4 @@
>    put here to instruct findbugs it must ignore them.
>  -->
>  <FindBugsFilter>
> -  <!--  Minimum JDK level is still 1.4, so valueOf(int) is not available -->
> -  <Match>
> -    <Class>*</Class>
> -    <Bug pattern="DM_NUMBER_CTOR" />
> -  </Match>
>  </FindBugsFilter>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r1485398 - /commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/findbugs-exclude-filter.xml

Posted by Gary Gregory <ga...@gmail.com>.
On Wed, May 22, 2013 at 8:53 PM, sebb <se...@gmail.com> wrote:

> On 22 May 2013 21:19,  <gg...@apache.org> wrote:
> > Author: ggregory
> > Date: Wed May 22 20:19:00 2013
> > New Revision: 1485398
> >
> > URL: http://svn.apache.org/r1485398
> > Log:
> > Remove rule that assumed DBCP 1.4 is on Java 1.4, it is on Java 6.
> >
>
> I'm not sure that's correct.
> Although the code is designed for JDBC 4 (Java 1.6), it can also be
> processed to generate code that supports JDBC 3 (Java 1.4/1.5)
>

>From reading the site, JDBC 3 is done in the DBCP_1_3_x_BRANCH.

Gary


> > Modified:
> >
> commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/findbugs-exclude-filter.xml
> >
> > Modified:
> commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/findbugs-exclude-filter.xml
> > URL:
> http://svn.apache.org/viewvc/commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/findbugs-exclude-filter.xml?rev=1485398&r1=1485397&r2=1485398&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/findbugs-exclude-filter.xml
> (original)
> > +++
> commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/findbugs-exclude-filter.xml
> Wed May 22 20:19:00 2013
> > @@ -22,9 +22,4 @@
> >    put here to instruct findbugs it must ignore them.
> >  -->
> >  <FindBugsFilter>
> > -  <!--  Minimum JDK level is still 1.4, so valueOf(int) is not
> available -->
> > -  <Match>
> > -    <Class>*</Class>
> > -    <Bug pattern="DM_NUMBER_CTOR" />
> > -  </Match>
> >  </FindBugsFilter>
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory