You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2015/05/09 00:55:00 UTC
[jira] [Commented] (HADOOP-10365) BufferedOutputStream in
FileUtil#unpackEntries() should be closed in finally block
[ https://issues.apache.org/jira/browse/HADOOP-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535813#comment-14535813 ]
Hadoop QA commented on HADOOP-10365:
------------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 15m 6s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac | 7m 40s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc | 9m 49s | There were no new javadoc warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 1m 7s | The applied patch generated 217 new checkstyle issues (total was 107, now 215). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. |
| {color:green}+1{color} | install | 1m 39s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 42s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | common tests | 23m 11s | Tests passed in hadoop-common. |
| | | 61m 15s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12731558/HADOOP-10365.5.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / d0e75e6 |
| checkstyle | https://builds.apache.org/job/PreCommit-HADOOP-Build/6555/artifact/patchprocess/diffcheckstylehadoop-common.txt |
| hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/6555/artifact/patchprocess/testrun_hadoop-common.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/6555/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6555/console |
This message was automatically generated.
> BufferedOutputStream in FileUtil#unpackEntries() should be closed in finally block
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-10365
> URL: https://issues.apache.org/jira/browse/HADOOP-10365
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Reporter: Ted Yu
> Assignee: Kiran Kumar M R
> Priority: Minor
> Labels: BB2015-05-RFC
> Attachments: HADOOP-10365.2.patch, HADOOP-10365.3.patch, HADOOP-10365.4.patch, HADOOP-10365.5.patch, HADOOP-10365.patch
>
>
> {code}
> BufferedOutputStream outputStream = new BufferedOutputStream(
> new FileOutputStream(outputFile));
> ...
> outputStream.flush();
> outputStream.close();
> {code}
> outputStream should be closed in finally block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)