You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@kudu.apache.org by "Ashwani Raina (Code Review)" <ge...@cloudera.org> on 2025/11/24 20:15:46 UTC

[kudu-CR] [squeasel] Set IPV6 V6ONLY sockopt for webserver

Ashwani Raina has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23710


Change subject: [squeasel] Set IPV6_V6ONLY sockopt for webserver
......................................................................

[squeasel] Set IPV6_V6ONLY sockopt for webserver

This patch adds config inside config_options for callers to set socket
option i.e. IPV6_V6ONLY. This is useful when webserver is expected to
serve only IPv6 requests and refuse any IPv4 request.
Also, a couple of unit tests are added to test two scenarios:
1. Webserver running in dual stack mode. Both types of connection
   requests i.e., IPv4 and IPv6, are accepted by the server.
2. Webserver running in IPv6-only mode. Only one type of connection
   i.e., IPv6, is accepted by the server.

Change-Id: I3db4195c82ee1e7843a3ea84681e080905030eb7
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/squeasel-ipv6-only-socket-option.patch
2 files changed, 371 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/23710/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3db4195c82ee1e7843a3ea84681e080905030eb7
Gerrit-Change-Number: 23710
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>

[kudu-CR] KUDU-1457 [6/n] Enable IPv6-only mode for webserver

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.

Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23710 )

Change subject: KUDU-1457 [6/n] Enable IPv6-only mode for webserver
......................................................................


Patch Set 3: Verified+1 Code-Review+2

unrelated test failures:
debug: memory_gc-itest.0
release: raft_consensus-itest.0, auto_rebalancer-test.0


-- 
To view, visit http://gerrit.cloudera.org:8080/23710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3db4195c82ee1e7843a3ea84681e080905030eb7
Gerrit-Change-Number: 23710
Gerrit-PatchSet: 3
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Feb 2026 16:02:45 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1457 [6/n] Enable IPv6-only mode for webserver

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.

Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23710 )

Change subject: KUDU-1457 [6/n] Enable IPv6-only mode for webserver
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/2166/


-- 
To view, visit http://gerrit.cloudera.org:8080/23710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3db4195c82ee1e7843a3ea84681e080905030eb7
Gerrit-Change-Number: 23710
Gerrit-PatchSet: 2
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 24 Nov 2025 20:23:12 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1457 [6/n] Enable IPv6-only mode for webserver

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23710 )

Change subject: KUDU-1457 [6/n] Enable IPv6-only mode for webserver
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23710/2/thirdparty/patches/squeasel-ipv6-only-socket-option.patch
File thirdparty/patches/squeasel-ipv6-only-socket-option.patch:

http://gerrit.cloudera.org:8080/#/c/23710/2/thirdparty/patches/squeasel-ipv6-only-socket-option.patch@28
PS2, Line 28: sock_ipv6_v6only
Why not just 'use_ipv6_only'?  Current name looks a bit self-duplicating in parts.



-- 
To view, visit http://gerrit.cloudera.org:8080/23710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3db4195c82ee1e7843a3ea84681e080905030eb7
Gerrit-Change-Number: 23710
Gerrit-PatchSet: 2
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Jan 2026 06:48:24 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1457 [6/n] Enable IPv6-only mode for webserver

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.

Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23710 )

Change subject: KUDU-1457 [6/n] Enable IPv6-only mode for webserver
......................................................................

KUDU-1457 [6/n] Enable IPv6-only mode for webserver

This patch adds config inside config_options for callers to set socket
option i.e. IPV6_V6ONLY. This is useful when webserver is expected to
serve only IPv6 requests and refuse any IPv4 request.
Also, a couple of unit tests are added to test two scenarios:
1. Webserver running in dual stack mode. Both types of connection
   requests i.e., IPv4 and IPv6, are accepted by the server.
2. Webserver running in IPv6-only mode. Only one type of connection
   i.e., IPv6, is accepted by the server.

Change-Id: I3db4195c82ee1e7843a3ea84681e080905030eb7
Reviewed-on: http://gerrit.cloudera.org:8080/23710
Reviewed-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Marton Greber <gr...@gmail.com>
Tested-by: Marton Greber <gr...@gmail.com>
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/squeasel-ipv6-only-socket-option.patch
2 files changed, 371 insertions(+), 2 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Marton Greber: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/23710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3db4195c82ee1e7843a3ea84681e080905030eb7
Gerrit-Change-Number: 23710
Gerrit-PatchSet: 4
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR] KUDU-1457 [6/n] Enable IPv6-only mode for webserver

Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.

Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23710

to look at the new patch set (#2).

Change subject: KUDU-1457 [6/n] Enable IPv6-only mode for webserver
......................................................................

KUDU-1457 [6/n] Enable IPv6-only mode for webserver

This patch adds config inside config_options for callers to set socket
option i.e. IPV6_V6ONLY. This is useful when webserver is expected to
serve only IPv6 requests and refuse any IPv4 request.
Also, a couple of unit tests are added to test two scenarios:
1. Webserver running in dual stack mode. Both types of connection
   requests i.e., IPv4 and IPv6, are accepted by the server.
2. Webserver running in IPv6-only mode. Only one type of connection
   i.e., IPv6, is accepted by the server.

Change-Id: I3db4195c82ee1e7843a3ea84681e080905030eb7
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/squeasel-ipv6-only-socket-option.patch
2 files changed, 371 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/23710/2
-- 
To view, visit http://gerrit.cloudera.org:8080/23710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3db4195c82ee1e7843a3ea84681e080905030eb7
Gerrit-Change-Number: 23710
Gerrit-PatchSet: 2
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1457 [6/n] Enable IPv6-only mode for webserver

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.

Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23710 )

Change subject: KUDU-1457 [6/n] Enable IPv6-only mode for webserver
......................................................................


Patch Set 3:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/2216/


-- 
To view, visit http://gerrit.cloudera.org:8080/23710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3db4195c82ee1e7843a3ea84681e080905030eb7
Gerrit-Change-Number: 23710
Gerrit-PatchSet: 3
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Jan 2026 06:40:36 +0000
Gerrit-HasComments: No