You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "KeDeng (Code Review)" <ge...@cloudera.org> on 2024/04/09 09:08:28 UTC
[kudu-CR] [tests] Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks
KeDeng has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21268
Change subject: [tests] Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks
......................................................................
[tests] Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks
The reason for the flakiness of the unit test is that we did not consider corner
cases, namely, the time reserved from detecting a table in soft-deleted state
until the execution of deletion, during which some operations may occur. We need
to reserve more time.
However, in order to verify that FLAGS_table_reserve_seconds is indeed effective,
the additional time cannot be too long. Taking these two factors into consideration,
I added one second of waiting time and performed multiple tests locally using the
gtest_repeat parameter to ensure that this modification is effective.
Change-Id: Iab3a6a5f54701470e368c043133f4646aa71126d
---
M src/kudu/client/client-test.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/21268/1
--
To view, visit http://gerrit.cloudera.org:8080/21268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab3a6a5f54701470e368c043133f4646aa71126d
Gerrit-Change-Number: 21268
Gerrit-PatchSet: 1
Gerrit-Owner: KeDeng <kd...@gmail.com>
[kudu-CR] KUDU-3433 Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21268 )
Change subject: KUDU-3433 Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks
......................................................................
Patch Set 2: Code-Review+2
Thank you for the fix!
--
To view, visit http://gerrit.cloudera.org:8080/21268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab3a6a5f54701470e368c043133f4646aa71126d
Gerrit-Change-Number: 21268
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Comment-Date: Tue, 09 Apr 2024 15:58:46 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3433 Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21268 )
Change subject: KUDU-3433 Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks
......................................................................
KUDU-3433 Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks
The reason for the flakiness of the unit test is that we did not consider corner
cases, namely, the time reserved from detecting a table in soft-deleted state
until the execution of deletion, during which some operations may occur. We need
to reserve more time.
However, in order to verify that FLAGS_table_reserve_seconds is indeed effective,
the additional time cannot be too long. Taking these two factors into consideration,
I added one second of waiting time and performed multiple tests locally using the
gtest_repeat parameter to ensure that this modification is effective.
Change-Id: Iab3a6a5f54701470e368c043133f4646aa71126d
Reviewed-on: http://gerrit.cloudera.org:8080/21268
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/client/client-test.cc
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab3a6a5f54701470e368c043133f4646aa71126d
Gerrit-Change-Number: 21268
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
[kudu-CR] KUDU-3433 Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks
Posted by "KeDeng (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21268
to look at the new patch set (#2).
Change subject: KUDU-3433 Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks
......................................................................
KUDU-3433 Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks
The reason for the flakiness of the unit test is that we did not consider corner
cases, namely, the time reserved from detecting a table in soft-deleted state
until the execution of deletion, during which some operations may occur. We need
to reserve more time.
However, in order to verify that FLAGS_table_reserve_seconds is indeed effective,
the additional time cannot be too long. Taking these two factors into consideration,
I added one second of waiting time and performed multiple tests locally using the
gtest_repeat parameter to ensure that this modification is effective.
Change-Id: Iab3a6a5f54701470e368c043133f4646aa71126d
---
M src/kudu/client/client-test.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/21268/2
--
To view, visit http://gerrit.cloudera.org:8080/21268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iab3a6a5f54701470e368c043133f4646aa71126d
Gerrit-Change-Number: 21268
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
[kudu-CR] KUDU-3433 Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21268 )
Change subject: KUDU-3433 Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks
......................................................................
Patch Set 2: Verified+1
I verified that the fix works: prior to the fix, the test scenario failed approximately 1 out of 10 runs. With this patch, 100 runs of the test scenario produced no failures.
--
To view, visit http://gerrit.cloudera.org:8080/21268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab3a6a5f54701470e368c043133f4646aa71126d
Gerrit-Change-Number: 21268
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Comment-Date: Tue, 09 Apr 2024 15:58:36 +0000
Gerrit-HasComments: No