You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jens Deppe <jd...@pivotal.io> on 2016/05/27 15:58:43 UTC
Review Request 47958: GEODE-1463: Legacy OperationContexts do not set
the appropriate Shiro permission tuple
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47958/
-----------------------------------------------------------
Review request for geode, Darrel Schneider, Jinmei Liao, Kevin Duling, and Kirk Lund.
Repository: geode
Description
-------
- Moved ResourceOperationContext into a 'public' package
- Marked GetOperationContext as abstract seeing that
GetOperationContextImpl extends it and there are no uses of
GetOperationContext anywhere. (So why does it still exist?).
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/ExecuteFunctionOperationContext.java e6bd455c0faa15e7ca63a6f96d8adb4f93043a8b
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/GetDurableCQsOperationContext.java a8de1a95e4aea8f077022fe0bb1d83bddf53c09b
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/GetOperationContext.java 43b9e3aab0a20d2c149879bb04977631dd4e918a
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/KeyOperationContext.java 71430afff5eeac8ed611461a7f2537bf25ffd9a1
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/KeyValueOperationContext.java 7f7ab8c404ce7ac47643eaad9723f83780fcba55
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/OperationContext.java 317fee6b62d084716565f008d4d99ea6376b28dc
geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java 4eafada199b5a6fb1e9a507eb0db02cc9525d0a3
geode-core/src/main/java/com/gemstone/gemfire/internal/security/shiro/CustomAuthRealm.java cb2b66be94f046dc60f811bceccdc68a239299e3
geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/MBeanServerWrapper.java 99cbe2e4c5f11cd2adfc40637f9e949a04d0ff61
geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/ResourceOperationContext.java 99da1f1abe00feddc806ca012d9a5d2c1ccd75b5
geode-core/src/test/java/com/gemstone/gemfire/cache/operations/OperationPartsJUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/ExampleJSONAuthorization.java f34be0b5ce4d833b60a20dced38a57e72eda1670
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/JSONAuthorization.java e14d1def97a06e479cbeeffe56a05e8e8de16d65
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/ResourceOperationContextJUnitTest.java 46c0e1ddb0ed7b0f9d881da48d6ce53bc3097e41
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestCommand.java 2ddc6eee691b7305a0618f9a40e03a39526bc7b5
Diff: https://reviews.apache.org/r/47958/diff/
Testing
-------
precheckin running
Thanks,
Jens Deppe
Re: Review Request 47958: GEODE-1463: Legacy OperationContexts do not
set the appropriate Shiro permission tuple
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47958/
-----------------------------------------------------------
(Updated May 27, 2016, 4 p.m.)
Review request for geode, Darrel Schneider, Jinmei Liao, Kevin Duling, and Kirk Lund.
Repository: geode
Description (updated)
-------
- Moved ResourceOperationContext into a 'public' package
- Marked GetOperationContext as abstract seeing that
GetOperationContextImpl extends it and there are no uses of
GetOperationContext anywhere. (So why does it still exist?).
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/ExecuteFunctionOperationContext.java e6bd455c0faa15e7ca63a6f96d8adb4f93043a8b
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/GetDurableCQsOperationContext.java a8de1a95e4aea8f077022fe0bb1d83bddf53c09b
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/GetOperationContext.java 43b9e3aab0a20d2c149879bb04977631dd4e918a
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/KeyOperationContext.java 71430afff5eeac8ed611461a7f2537bf25ffd9a1
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/KeyValueOperationContext.java 7f7ab8c404ce7ac47643eaad9723f83780fcba55
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/OperationContext.java 317fee6b62d084716565f008d4d99ea6376b28dc
geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java 4eafada199b5a6fb1e9a507eb0db02cc9525d0a3
geode-core/src/main/java/com/gemstone/gemfire/internal/security/shiro/CustomAuthRealm.java cb2b66be94f046dc60f811bceccdc68a239299e3
geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/MBeanServerWrapper.java 99cbe2e4c5f11cd2adfc40637f9e949a04d0ff61
geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/ResourceOperationContext.java 99da1f1abe00feddc806ca012d9a5d2c1ccd75b5
geode-core/src/test/java/com/gemstone/gemfire/cache/operations/OperationPartsJUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/ExampleJSONAuthorization.java f34be0b5ce4d833b60a20dced38a57e72eda1670
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/JSONAuthorization.java e14d1def97a06e479cbeeffe56a05e8e8de16d65
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/ResourceOperationContextJUnitTest.java 46c0e1ddb0ed7b0f9d881da48d6ce53bc3097e41
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestCommand.java 2ddc6eee691b7305a0618f9a40e03a39526bc7b5
Diff: https://reviews.apache.org/r/47958/diff/
Testing
-------
precheckin running
Thanks,
Jens Deppe
Re: Review Request 47958: GEODE-1463: Legacy OperationContexts do not
set the appropriate Shiro permission tuple
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47958/
-----------------------------------------------------------
(Updated May 27, 2016, 3:59 p.m.)
Review request for geode, Darrel Schneider, Jinmei Liao, Kevin Duling, and Kirk Lund.
Repository: geode
Description (updated)
-------
- Moved ResourceOperationContext into a 'public' package
- Marked GetOperationContext as abstract seeing that
GetOperationContextImpl extends it and there are no uses of
GetOperationContext anywhere. (So why does it still exist?).
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/ExecuteFunctionOperationContext.java e6bd455c0faa15e7ca63a6f96d8adb4f93043a8b
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/GetDurableCQsOperationContext.java a8de1a95e4aea8f077022fe0bb1d83bddf53c09b
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/GetOperationContext.java 43b9e3aab0a20d2c149879bb04977631dd4e918a
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/KeyOperationContext.java 71430afff5eeac8ed611461a7f2537bf25ffd9a1
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/KeyValueOperationContext.java 7f7ab8c404ce7ac47643eaad9723f83780fcba55
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/OperationContext.java 317fee6b62d084716565f008d4d99ea6376b28dc
geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java 4eafada199b5a6fb1e9a507eb0db02cc9525d0a3
geode-core/src/main/java/com/gemstone/gemfire/internal/security/shiro/CustomAuthRealm.java cb2b66be94f046dc60f811bceccdc68a239299e3
geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/MBeanServerWrapper.java 99cbe2e4c5f11cd2adfc40637f9e949a04d0ff61
geode-core/src/main/java/com/gemstone/gemfire/management/internal/security/ResourceOperationContext.java 99da1f1abe00feddc806ca012d9a5d2c1ccd75b5
geode-core/src/test/java/com/gemstone/gemfire/cache/operations/OperationPartsJUnitTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/ExampleJSONAuthorization.java f34be0b5ce4d833b60a20dced38a57e72eda1670
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/JSONAuthorization.java e14d1def97a06e479cbeeffe56a05e8e8de16d65
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/ResourceOperationContextJUnitTest.java 46c0e1ddb0ed7b0f9d881da48d6ce53bc3097e41
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestCommand.java 2ddc6eee691b7305a0618f9a40e03a39526bc7b5
Diff: https://reviews.apache.org/r/47958/diff/
Testing
-------
precheckin running
Thanks,
Jens Deppe