You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2019/03/26 04:39:40 UTC

[james-project] 09/10: JAMES-2682 Fix checkstyle

This is an automated email from the ASF dual-hosted git repository.

btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit 975b9bc32b3e8d8269ccd816e4e59e341b8fa478
Author: Pablo Pita <pa...@gmail.com>
AuthorDate: Mon Mar 18 20:20:15 2019 +0100

    JAMES-2682 Fix checkstyle
---
 .../james/transport/mailets/jsieve/delivery/SieveExecutor.java      | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/jsieve/delivery/SieveExecutor.java b/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/jsieve/delivery/SieveExecutor.java
index 3fed2ff..cdcc51d 100644
--- a/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/jsieve/delivery/SieveExecutor.java
+++ b/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/jsieve/delivery/SieveExecutor.java
@@ -21,7 +21,6 @@
 package org.apache.james.transport.mailets.jsieve.delivery;
 
 import java.io.IOException;
-import java.util.Optional;
 
 import javax.mail.MessagingException;
 
@@ -121,10 +120,7 @@ public class SieveExecutor {
         Preconditions.checkNotNull(recipient, "Recipient for mail to be spooled cannot be null.");
         Preconditions.checkNotNull(mail.getMessage(), "Mail message to be spooled cannot be null.");
         boolean isSieveNotification = AttributeUtils.getValueAndCastFromMail(mail, SIEVE_NOTIFICATION, Boolean.class).orElse(false);
-        if (isSieveNotification) {
-           	return false;
-        }
-        return sieveMessage(recipient, mail);
+        return !isSieveNotification ? sieveMessage(recipient, mail) : false;
     }
 
     protected boolean sieveMessage(MailAddress recipient, Mail aMail) throws MessagingException {


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org