You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by zhou xing <xi...@cn.ibm.com> on 2016/04/14 09:28:21 UTC
Review Request 46189: Slave rename - Update strings in error messages
and other strings.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46189/
-----------------------------------------------------------
Review request for mesos, Kevin Klues and Vinod Kone.
Bugs: MESOS-5057
https://issues.apache.org/jira/browse/MESOS-5057
Repository: mesos
Description
-------
[#MESOS-5057]
This patch renames 'slave' to 'agent' in the following strings:
1. Error/Warning messages
2. Flag help/description messages
3. Test case messages
4. Other standard output messages
Diffs
-----
CHANGELOG 1e07c8c2de8eff87c171378ef207c91a20d435d9
src/common/resources_utils.cpp 70e6f025d89383084ab8b2cda23ab1cd55d959b2
src/examples/dynamic_reservation_framework.cpp 8f00bcf50c25cf46c3dc32e3e77370b39fbd46bc
src/hook/manager.cpp 692b9ea862442f3bac58da678425f03e4b00a79d
src/internal/devolve.cpp 0f58dc151c3de5a25d0ca73030a8222cac0f43c1
src/local/flags.hpp b3cd811c78bb7b57d82d755e36a89269d8173c2d
src/logging/flags.cpp 446eb921443481f4025132653e0bfa8ab42aa240
src/master/flags.cpp e522499586b731d522180f171731a9dd38b8344c
src/master/http.cpp b8a83b58b60416f61610cad16fc6f70028a5ee10
src/master/master.hpp 1f480f03900a0dc2996c2ed3a9534dfa8036940f
src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c
src/master/validation.cpp 13423436a4e6361fde6fa75133eebf5c02c8381f
src/python/executor/src/mesos/executor/mesos_executor_driver_impl.cpp 843771ae5b4f7e283d85c093e63c235dc753397d
src/python/scheduler/src/mesos/scheduler/mesos_scheduler_driver_impl.cpp 78dc298ec19a61cd491b2b43b463db67528c5526
src/scaling/scaling_sched.py d1008c79b1f1302d9ff6ae6dc9e1d9d0b7379773
src/sched/sched.cpp 5f6f5518f0858c680dc0dffc933c0bb03bba6991
src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 4f3f210b8d0ab9a453ab56c5e23024e2ab7c4259
src/slave/flags.cpp 316feec26e52a8cb1f0fd0739176b3f502e1ed86
src/slave/http.cpp 922aaad6e83ca9d5ab503ddb733a332982843300
src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48
src/slave/slave.cpp 49fa4a06e26d0d4475ed50db254a320a7030f896
src/slave/state.cpp e7b44c78500e07f0f1655f41a6a977adae2ca0c0
src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c
src/tests/containerizer/docker_containerizer_tests.cpp 7accd32fba5eed196a82b1a171cb16d37b9e0539
src/tests/containerizer/filesystem_isolator_tests.cpp 51e60c2e8c6c8b76b51de0e7761ecbb0ca9c3304
src/tests/flags.hpp af15360491b5433dcfbda03a72407667eb3977d1
src/tests/hierarchical_allocator_tests.cpp 8ed0df45fc745d338482d1944a346cd40c18bb37
src/tests/master_allocator_tests.cpp 17607df7d488c8dd42c57504a5ca326697f57ffa
src/tests/master_tests.cpp 1ae72600e26c5f31476f689cbb600d41d7cc9b74
src/tests/paths_tests.cpp 81498e368cbb77e2cb8af71d8570dc690d3d0dfc
src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8
src/tests/sorter_tests.cpp 0f3266f1222163c4d03eb4c4ca88f96836de601e
Diff: https://reviews.apache.org/r/46189/diff/
Testing
-------
make
make check
Thanks,
zhou xing
Re: Review Request 46189: Slave rename - Update strings in error
messages and other strings.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46189/#review129194
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On April 14, 2016, 11:27 p.m., zhou xing wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46189/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 11:27 p.m.)
>
>
> Review request for mesos, Kevin Klues and Vinod Kone.
>
>
> Bugs: MESOS-5057
> https://issues.apache.org/jira/browse/MESOS-5057
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [#MESOS-5057]
> This patch renames 'slave' to 'agent' in the following strings:
> 1. Error/Warning messages
> 2. Flag help/description messages
> 3. Test case messages
> 4. Other standard output messages
>
>
> Diffs
> -----
>
> CHANGELOG 1e07c8c2de8eff87c171378ef207c91a20d435d9
> src/common/resources_utils.cpp 70e6f025d89383084ab8b2cda23ab1cd55d959b2
> src/examples/dynamic_reservation_framework.cpp 8f00bcf50c25cf46c3dc32e3e77370b39fbd46bc
> src/hook/manager.cpp 692b9ea862442f3bac58da678425f03e4b00a79d
> src/internal/devolve.cpp 0f58dc151c3de5a25d0ca73030a8222cac0f43c1
> src/local/flags.hpp b3cd811c78bb7b57d82d755e36a89269d8173c2d
> src/logging/flags.cpp 446eb921443481f4025132653e0bfa8ab42aa240
> src/master/flags.cpp e522499586b731d522180f171731a9dd38b8344c
> src/master/http.cpp b8a83b58b60416f61610cad16fc6f70028a5ee10
> src/master/master.hpp 1f480f03900a0dc2996c2ed3a9534dfa8036940f
> src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c
> src/master/validation.cpp 13423436a4e6361fde6fa75133eebf5c02c8381f
> src/python/executor/src/mesos/executor/mesos_executor_driver_impl.cpp 843771ae5b4f7e283d85c093e63c235dc753397d
> src/python/scheduler/src/mesos/scheduler/mesos_scheduler_driver_impl.cpp 78dc298ec19a61cd491b2b43b463db67528c5526
> src/scaling/scaling_sched.py d1008c79b1f1302d9ff6ae6dc9e1d9d0b7379773
> src/sched/sched.cpp 5f6f5518f0858c680dc0dffc933c0bb03bba6991
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 4f3f210b8d0ab9a453ab56c5e23024e2ab7c4259
> src/slave/flags.cpp 316feec26e52a8cb1f0fd0739176b3f502e1ed86
> src/slave/http.cpp 922aaad6e83ca9d5ab503ddb733a332982843300
> src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48
> src/slave/slave.cpp 49fa4a06e26d0d4475ed50db254a320a7030f896
> src/slave/state.cpp e7b44c78500e07f0f1655f41a6a977adae2ca0c0
> src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c
> src/tests/containerizer/docker_containerizer_tests.cpp 7accd32fba5eed196a82b1a171cb16d37b9e0539
> src/tests/containerizer/filesystem_isolator_tests.cpp 51e60c2e8c6c8b76b51de0e7761ecbb0ca9c3304
> src/tests/flags.hpp af15360491b5433dcfbda03a72407667eb3977d1
> src/tests/hierarchical_allocator_tests.cpp 8ed0df45fc745d338482d1944a346cd40c18bb37
> src/tests/master_allocator_tests.cpp 17607df7d488c8dd42c57504a5ca326697f57ffa
> src/tests/master_tests.cpp 1ae72600e26c5f31476f689cbb600d41d7cc9b74
> src/tests/paths_tests.cpp 81498e368cbb77e2cb8af71d8570dc690d3d0dfc
> src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8
> src/tests/sorter_tests.cpp 0f3266f1222163c4d03eb4c4ca88f96836de601e
>
> Diff: https://reviews.apache.org/r/46189/diff/
>
>
> Testing
> -------
>
> Perform the following regular expression on 'mesos/src' and 'mesos/support' folder to find out all the message strings(in Eclipse IDE):
> ```
> ^[^#include].*".*slave.*"
> ```
> then filter out the lines that using term 'slave' as the field name or attribute name
>
> make
> make check
>
>
> Thanks,
>
> zhou xing
>
>
Re: Review Request 46189: Slave rename - Update strings in error
messages and other strings.
Posted by zhou xing <xi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46189/
-----------------------------------------------------------
(Updated 四月 18, 2016, 2:31 a.m.)
Review request for mesos, Kevin Klues and Vinod Kone.
Changes
-------
rebased the code
Bugs: MESOS-5057
https://issues.apache.org/jira/browse/MESOS-5057
Repository: mesos
Description
-------
[#MESOS-5057]
This patch renames 'slave' to 'agent' in the following strings:
1. Error/Warning messages
2. Flag help/description messages
3. Test case messages
4. Other standard output messages
Diffs (updated)
-----
CHANGELOG 915c592b34e080b8227bf4c829db08cd7e497305
src/common/resources_utils.cpp 70e6f025d89383084ab8b2cda23ab1cd55d959b2
src/examples/dynamic_reservation_framework.cpp 8f00bcf50c25cf46c3dc32e3e77370b39fbd46bc
src/hook/manager.cpp 692b9ea862442f3bac58da678425f03e4b00a79d
src/internal/devolve.cpp 0f58dc151c3de5a25d0ca73030a8222cac0f43c1
src/local/flags.hpp b3cd811c78bb7b57d82d755e36a89269d8173c2d
src/logging/flags.cpp 446eb921443481f4025132653e0bfa8ab42aa240
src/master/flags.cpp 989bc980e3e8ebe1f7ebc471ed44df5ddb65510f
src/master/http.cpp d83ccd394c688803369034e22de79b40277a3a7c
src/master/master.hpp 2dd0971a484cef0360237ff9e5e80cc10db9e20e
src/master/master.cpp 210934b6cda1c62cd478de9f39b1561f231406f0
src/master/validation.cpp 2b91446edeb1c0afda4ffcb4d140178cdde44862
src/python/executor/src/mesos/executor/mesos_executor_driver_impl.cpp 843771ae5b4f7e283d85c093e63c235dc753397d
src/python/scheduler/src/mesos/scheduler/mesos_scheduler_driver_impl.cpp 78dc298ec19a61cd491b2b43b463db67528c5526
src/scaling/scaling_sched.py d1008c79b1f1302d9ff6ae6dc9e1d9d0b7379773
src/sched/sched.cpp 5f6f5518f0858c680dc0dffc933c0bb03bba6991
src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 4f3f210b8d0ab9a453ab56c5e23024e2ab7c4259
src/slave/flags.cpp 316feec26e52a8cb1f0fd0739176b3f502e1ed86
src/slave/http.cpp 3f96f2c201597706dfc814c0a20bb983cd56905a
src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48
src/slave/slave.cpp de99e9eb5cc812b2e07deb749b98b4f4db363728
src/slave/state.cpp e7b44c78500e07f0f1655f41a6a977adae2ca0c0
src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c
src/tests/containerizer/docker_containerizer_tests.cpp 7accd32fba5eed196a82b1a171cb16d37b9e0539
src/tests/containerizer/filesystem_isolator_tests.cpp 51e60c2e8c6c8b76b51de0e7761ecbb0ca9c3304
src/tests/flags.hpp af15360491b5433dcfbda03a72407667eb3977d1
src/tests/hierarchical_allocator_tests.cpp 8ed0df45fc745d338482d1944a346cd40c18bb37
src/tests/master_allocator_tests.cpp 17607df7d488c8dd42c57504a5ca326697f57ffa
src/tests/master_tests.cpp cdd69b61349185e74d90e6b50e31d16ad8c0eabf
src/tests/paths_tests.cpp 81498e368cbb77e2cb8af71d8570dc690d3d0dfc
src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8
src/tests/sorter_tests.cpp 0f3266f1222163c4d03eb4c4ca88f96836de601e
Diff: https://reviews.apache.org/r/46189/diff/
Testing
-------
Perform the following regular expression on 'mesos/src' and 'mesos/support' folder to find out all the message strings(in Eclipse IDE):
```
^[^#include].*".*slave.*"
```
then filter out the lines that using term 'slave' as the field name or attribute name
make
make check
Thanks,
zhou xing
Re: Review Request 46189: Slave rename - Update strings in error
messages and other strings.
Posted by zhou xing <xi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46189/
-----------------------------------------------------------
(Updated 四月 14, 2016, 11:27 p.m.)
Review request for mesos, Kevin Klues and Vinod Kone.
Bugs: MESOS-5057
https://issues.apache.org/jira/browse/MESOS-5057
Repository: mesos
Description
-------
[#MESOS-5057]
This patch renames 'slave' to 'agent' in the following strings:
1. Error/Warning messages
2. Flag help/description messages
3. Test case messages
4. Other standard output messages
Diffs
-----
CHANGELOG 1e07c8c2de8eff87c171378ef207c91a20d435d9
src/common/resources_utils.cpp 70e6f025d89383084ab8b2cda23ab1cd55d959b2
src/examples/dynamic_reservation_framework.cpp 8f00bcf50c25cf46c3dc32e3e77370b39fbd46bc
src/hook/manager.cpp 692b9ea862442f3bac58da678425f03e4b00a79d
src/internal/devolve.cpp 0f58dc151c3de5a25d0ca73030a8222cac0f43c1
src/local/flags.hpp b3cd811c78bb7b57d82d755e36a89269d8173c2d
src/logging/flags.cpp 446eb921443481f4025132653e0bfa8ab42aa240
src/master/flags.cpp e522499586b731d522180f171731a9dd38b8344c
src/master/http.cpp b8a83b58b60416f61610cad16fc6f70028a5ee10
src/master/master.hpp 1f480f03900a0dc2996c2ed3a9534dfa8036940f
src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c
src/master/validation.cpp 13423436a4e6361fde6fa75133eebf5c02c8381f
src/python/executor/src/mesos/executor/mesos_executor_driver_impl.cpp 843771ae5b4f7e283d85c093e63c235dc753397d
src/python/scheduler/src/mesos/scheduler/mesos_scheduler_driver_impl.cpp 78dc298ec19a61cd491b2b43b463db67528c5526
src/scaling/scaling_sched.py d1008c79b1f1302d9ff6ae6dc9e1d9d0b7379773
src/sched/sched.cpp 5f6f5518f0858c680dc0dffc933c0bb03bba6991
src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 4f3f210b8d0ab9a453ab56c5e23024e2ab7c4259
src/slave/flags.cpp 316feec26e52a8cb1f0fd0739176b3f502e1ed86
src/slave/http.cpp 922aaad6e83ca9d5ab503ddb733a332982843300
src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48
src/slave/slave.cpp 49fa4a06e26d0d4475ed50db254a320a7030f896
src/slave/state.cpp e7b44c78500e07f0f1655f41a6a977adae2ca0c0
src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c
src/tests/containerizer/docker_containerizer_tests.cpp 7accd32fba5eed196a82b1a171cb16d37b9e0539
src/tests/containerizer/filesystem_isolator_tests.cpp 51e60c2e8c6c8b76b51de0e7761ecbb0ca9c3304
src/tests/flags.hpp af15360491b5433dcfbda03a72407667eb3977d1
src/tests/hierarchical_allocator_tests.cpp 8ed0df45fc745d338482d1944a346cd40c18bb37
src/tests/master_allocator_tests.cpp 17607df7d488c8dd42c57504a5ca326697f57ffa
src/tests/master_tests.cpp 1ae72600e26c5f31476f689cbb600d41d7cc9b74
src/tests/paths_tests.cpp 81498e368cbb77e2cb8af71d8570dc690d3d0dfc
src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8
src/tests/sorter_tests.cpp 0f3266f1222163c4d03eb4c4ca88f96836de601e
Diff: https://reviews.apache.org/r/46189/diff/
Testing (updated)
-------
Perform the following regular expression on 'mesos/src' and 'mesos/support' folder to find out all the message strings(in Eclipse IDE):
```
^[^#include].*".*slave.*"
```
then filter out the lines that using term 'slave' as the field name or attribute name
make
make check
Thanks,
zhou xing
Re: Review Request 46189: Slave rename - Update strings in error
messages and other strings.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46189/#review128992
-----------------------------------------------------------
Can you comment in the testing section how you verified that you covered everything?
- Kevin Klues
On April 14, 2016, 7:28 a.m., zhou xing wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46189/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 7:28 a.m.)
>
>
> Review request for mesos, Kevin Klues and Vinod Kone.
>
>
> Bugs: MESOS-5057
> https://issues.apache.org/jira/browse/MESOS-5057
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [#MESOS-5057]
> This patch renames 'slave' to 'agent' in the following strings:
> 1. Error/Warning messages
> 2. Flag help/description messages
> 3. Test case messages
> 4. Other standard output messages
>
>
> Diffs
> -----
>
> CHANGELOG 1e07c8c2de8eff87c171378ef207c91a20d435d9
> src/common/resources_utils.cpp 70e6f025d89383084ab8b2cda23ab1cd55d959b2
> src/examples/dynamic_reservation_framework.cpp 8f00bcf50c25cf46c3dc32e3e77370b39fbd46bc
> src/hook/manager.cpp 692b9ea862442f3bac58da678425f03e4b00a79d
> src/internal/devolve.cpp 0f58dc151c3de5a25d0ca73030a8222cac0f43c1
> src/local/flags.hpp b3cd811c78bb7b57d82d755e36a89269d8173c2d
> src/logging/flags.cpp 446eb921443481f4025132653e0bfa8ab42aa240
> src/master/flags.cpp e522499586b731d522180f171731a9dd38b8344c
> src/master/http.cpp b8a83b58b60416f61610cad16fc6f70028a5ee10
> src/master/master.hpp 1f480f03900a0dc2996c2ed3a9534dfa8036940f
> src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c
> src/master/validation.cpp 13423436a4e6361fde6fa75133eebf5c02c8381f
> src/python/executor/src/mesos/executor/mesos_executor_driver_impl.cpp 843771ae5b4f7e283d85c093e63c235dc753397d
> src/python/scheduler/src/mesos/scheduler/mesos_scheduler_driver_impl.cpp 78dc298ec19a61cd491b2b43b463db67528c5526
> src/scaling/scaling_sched.py d1008c79b1f1302d9ff6ae6dc9e1d9d0b7379773
> src/sched/sched.cpp 5f6f5518f0858c680dc0dffc933c0bb03bba6991
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 4f3f210b8d0ab9a453ab56c5e23024e2ab7c4259
> src/slave/flags.cpp 316feec26e52a8cb1f0fd0739176b3f502e1ed86
> src/slave/http.cpp 922aaad6e83ca9d5ab503ddb733a332982843300
> src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48
> src/slave/slave.cpp 49fa4a06e26d0d4475ed50db254a320a7030f896
> src/slave/state.cpp e7b44c78500e07f0f1655f41a6a977adae2ca0c0
> src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c
> src/tests/containerizer/docker_containerizer_tests.cpp 7accd32fba5eed196a82b1a171cb16d37b9e0539
> src/tests/containerizer/filesystem_isolator_tests.cpp 51e60c2e8c6c8b76b51de0e7761ecbb0ca9c3304
> src/tests/flags.hpp af15360491b5433dcfbda03a72407667eb3977d1
> src/tests/hierarchical_allocator_tests.cpp 8ed0df45fc745d338482d1944a346cd40c18bb37
> src/tests/master_allocator_tests.cpp 17607df7d488c8dd42c57504a5ca326697f57ffa
> src/tests/master_tests.cpp 1ae72600e26c5f31476f689cbb600d41d7cc9b74
> src/tests/paths_tests.cpp 81498e368cbb77e2cb8af71d8570dc690d3d0dfc
> src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8
> src/tests/sorter_tests.cpp 0f3266f1222163c4d03eb4c4ca88f96836de601e
>
> Diff: https://reviews.apache.org/r/46189/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> zhou xing
>
>