You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/01 17:42:05 UTC

[GitHub] [tvm] quic-sanirudh opened a new pull request, #13257: [Hexagon] Fix Hexagon external libs check

quic-sanirudh opened a new pull request, #13257:
URL: https://github.com/apache/tvm/pull/13257

   When building tvm runtime with hexagon we face the below error if USE_HEXAGON_EXTERNAL_LIBS is not defined. This happens because USE_HEXAGON_EXTERNAL_LIBS=OFF is defined as the default in CMakeLists.txt. The modified condition can check for all cases including undefined variable, empty string and OFF
   
   ```
   CMake Error at cmake/modules/Hexagon.cmake:203 (message):
     Invalid use of USE_HEXAGON_EXTERNAL_LIBS=OFF; USE_HEXAGON_EXTERNAL_LIBS
     only supports absolute paths and git repository urls
   Call Stack (most recent call first):
     CMakeLists.txt:477 (include)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #13257: [Hexagon] Fix Hexagon external libs check

Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13257:
URL: https://github.com/apache/tvm/pull/13257#issuecomment-1298885177

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @mehrdadh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] kparzysz-quic commented on pull request #13257: [Hexagon] Fix Hexagon external libs check

Posted by GitBox <gi...@apache.org>.
kparzysz-quic commented on PR #13257:
URL: https://github.com/apache/tvm/pull/13257#issuecomment-1298978585

   @tvm-bot rerun


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] quic-sanirudh commented on pull request #13257: [Hexagon] Fix Hexagon external libs check

Posted by GitBox <gi...@apache.org>.
quic-sanirudh commented on PR #13257:
URL: https://github.com/apache/tvm/pull/13257#issuecomment-1298888124

   cc @csullivan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] driazati commented on pull request #13257: [Hexagon] Fix Hexagon external libs check

Posted by GitBox <gi...@apache.org>.
driazati commented on PR #13257:
URL: https://github.com/apache/tvm/pull/13257#issuecomment-1300937892

   It's since been fixed on `main` but you'll need to rebase this branch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] quic-sanirudh commented on pull request #13257: [Hexagon] Fix Hexagon external libs check

Posted by GitBox <gi...@apache.org>.
quic-sanirudh commented on PR #13257:
URL: https://github.com/apache/tvm/pull/13257#issuecomment-1299552828

   @tvm-bot rerun


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi merged pull request #13257: [Hexagon] Fix Hexagon external libs check

Posted by GitBox <gi...@apache.org>.
masahi merged PR #13257:
URL: https://github.com/apache/tvm/pull/13257


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org