You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/09/22 14:56:14 UTC

[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #3108: [GOBBLIN-1268] track WORK_UNITS_PREPARATION timer event also in gaas

sv2000 commented on a change in pull request #3108:
URL: https://github.com/apache/incubator-gobblin/pull/3108#discussion_r492802937



##########
File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
##########
@@ -493,6 +489,10 @@ public void forWorkUnit(WorkUnit workUnit) {
             }
           });
 
+          // If it is a streaming source, workunits cannot be counted

Review comment:
       Is there a unit test we can add for this? It seems like the previous location of this block was incorrect. To prevent future regression, it would be good to add a unit test for this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org