[GitHub] [hadoop-submarine] liuxunorg commented on a change in pull request #45: [SUBMARINE-237] workbench-daemon.sh script return wrong status of workbench

[GitBox <gi...@apache.org>]

liuxunorg commented on a change in pull request #45: [SUBMARINE-237] workbench-daemon.sh script return wrong status of workbench
URL: https://github.com/apache/hadoop-submarine/pull/45#discussion_r334359828
 
 

 ##########
 File path: bin/workbench-daemon.sh
 ##########
 @@ -148,15 +148,15 @@ function find_workbench_process() {
   pid=`found_workbench_server_pid`
 
   if [[ -z "$pid" ]]; then
-    if ! kill -0 ${pid} > /dev/null 2>&1; then
+    echo "${WORKBENCH_NAME} is not running"
+    return 1
+  else
+   if ! kill -0 ${pid} > /dev/null 2>&1; then
 
 Review comment:
   The first letter needs to be indented into two.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services