You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/11 07:40:31 UTC
[GitHub] [flink-connector-dynamodb] darenwkt opened a new pull request, #9: [FLINK-29443] Replicate packaging tests
darenwkt opened a new pull request, #9:
URL: https://github.com/apache/flink-connector-dynamodb/pull/9
Added skeleton packaging tests to test if build jar contains expected files.
Files to look for currently are:
- META-INF/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-dynamodb] dannycranmer commented on pull request #9: [FLINK-29443] Replicate packaging tests
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on PR #9:
URL: https://github.com/apache/flink-connector-dynamodb/pull/9#issuecomment-1277404827
@darenwkt the checks are failing on CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] dannycranmer merged pull request #9: [FLINK-29443] Replicate packaging tests
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer merged PR #9:
URL: https://github.com/apache/flink-connector-aws/pull/9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-dynamodb] darenwkt commented on a diff in pull request #9: [FLINK-29443] Replicate packaging tests
Posted by GitBox <gi...@apache.org>.
darenwkt commented on code in PR #9:
URL: https://github.com/apache/flink-connector-dynamodb/pull/9#discussion_r997002598
##########
flink-connector-dynamodb/pom.xml:
##########
@@ -33,6 +33,15 @@ under the License.
<artifactId>flink-connector-dynamodb</artifactId>
<name>Flink : Connectors : Amazon DynamoDB</name>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-test-utils</artifactId>
+ <version>1.16-SNAPSHOT</version>
Review Comment:
Had offline discussion with Danny, we will use 1.16-SNAPSHOT version as there is no released version for flink-test-utils and flink-ci-tools yet.
Todo: Once 1.16 is release, we will upgrade the version of dependencies in here to released verison
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-dynamodb] darenwkt commented on a diff in pull request #9: [FLINK-29443] Replicate packaging tests
Posted by GitBox <gi...@apache.org>.
darenwkt commented on code in PR #9:
URL: https://github.com/apache/flink-connector-dynamodb/pull/9#discussion_r997003296
##########
flink-connector-dynamodb/src/test/java/org/apache/flink/connectors/dynamodb/PackagingITCase.java:
##########
@@ -0,0 +1,19 @@
+package org.apache.flink.connectors.dynamodb;
+
+import org.apache.flink.packaging.PackagingTestUtils;
+import org.apache.flink.test.resources.ResourceTestUtils;
+
+import org.junit.jupiter.api.Test;
+
+import java.nio.file.Path;
+import java.util.Arrays;
+
+/** Test to verify contents of packaged jar. */
+public class PackagingITCase {
+ @Test
+ void testPackaging() throws Exception {
+ final Path jar = ResourceTestUtils.getResource(".*/flink-connector-dynamodb-[^/]*\\.jar");
+
+ PackagingTestUtils.assertJarContainsOnlyFilesMatching(jar, Arrays.asList("META-INF/"));
Review Comment:
I have relax the regex to match any dir name prefix with "flink-"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-dynamodb] dannycranmer commented on a diff in pull request #9: [FLINK-29443] Replicate packaging tests
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on code in PR #9:
URL: https://github.com/apache/flink-connector-dynamodb/pull/9#discussion_r995487077
##########
flink-connector-dynamodb/pom.xml:
##########
@@ -33,6 +33,15 @@ under the License.
<artifactId>flink-connector-dynamodb</artifactId>
<name>Flink : Connectors : Amazon DynamoDB</name>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-test-utils</artifactId>
+ <version>1.16-SNAPSHOT</version>
Review Comment:
Why are we depending on a snapshot version and not the parent Flink version? Can this dependency not be managed from the dynamodb parent pom?
##########
flink-sql-connector-dynamodb/pom.xml:
##########
@@ -51,6 +51,13 @@ under the License.
<artifactId>flink-connector-dynamodb</artifactId>
<version>${project.version}</version>
</dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-test-utils</artifactId>
+ <version>1.16-SNAPSHOT</version>
Review Comment:
Same as above
##########
flink-connector-dynamodb/src/test/java/org/apache/flink/connectors/dynamodb/PackagingITCase.java:
##########
@@ -0,0 +1,19 @@
+package org.apache.flink.connectors.dynamodb;
+
+import org.apache.flink.packaging.PackagingTestUtils;
+import org.apache.flink.test.resources.ResourceTestUtils;
+
+import org.junit.jupiter.api.Test;
+
+import java.nio.file.Path;
+import java.util.Arrays;
+
+/** Test to verify contents of packaged jar. */
+public class PackagingITCase {
+ @Test
+ void testPackaging() throws Exception {
+ final Path jar = ResourceTestUtils.getResource(".*/flink-connector-dynamodb-[^/]*\\.jar");
+
+ PackagingTestUtils.assertJarContainsOnlyFilesMatching(jar, Arrays.asList("META-INF/"));
Review Comment:
This will break the build for the main code contribution I assume. Can we relax this check to support the intended result? We expect class file etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-dynamodb] dannycranmer commented on pull request #9: [FLINK-29443] Replicate packaging tests
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on PR #9:
URL: https://github.com/apache/flink-connector-dynamodb/pull/9#issuecomment-1278660043
@darenwkt please squash commits and fix commit message to comply with the [contribution guide](https://flink.apache.org/contributing/contribute-documentation.html#submit-your-contribution)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org