You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Yan Fang <ya...@gmail.com> on 2015/02/12 10:04:42 UTC
Review Request 30920: SAMZA-554: Simplify serde configuration by
providing default serde names
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30920/
-----------------------------------------------------------
Review request for samza.
Bugs: SAMZA-554
https://issues.apache.org/jira/browse/SAMZA-554
Repository: samza
Description
-------
provide a method which looks for the serdes in the system when can not find in properties file
Diffs
-----
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 8a6d865
Diff: https://reviews.apache.org/r/30920/diff/
Testing
-------
Thanks,
Yan Fang
Re: Review Request 30920: SAMZA-554: Simplify serde configuration by
providing default serde names
Posted by Yan Fang <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30920/
-----------------------------------------------------------
(Updated Feb. 17, 2015, 10:08 p.m.)
Review request for samza.
Bugs: SAMZA-554
https://issues.apache.org/jira/browse/SAMZA-554
Repository: samza
Description
-------
provide a method which looks for the serdes in the system when can not find in properties file
Diffs (updated)
-----
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala ac6e24f
samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala 19ceeaa
Diff: https://reviews.apache.org/r/30920/diff/
Testing
-------
Thanks,
Yan Fang
Re: Review Request 30920: SAMZA-554: Simplify serde configuration by
providing default serde names
Posted by Yan Fang <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30920/
-----------------------------------------------------------
(Updated Feb. 13, 2015, 11:40 p.m.)
Review request for samza.
Changes
-------
move to a seperate function
add unit test
add log.info()
Bugs: SAMZA-554
https://issues.apache.org/jira/browse/SAMZA-554
Repository: samza
Description
-------
provide a method which looks for the serdes in the system when can not find in properties file
Diffs (updated)
-----
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala ac6e24f
samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala 19ceeaa
Diff: https://reviews.apache.org/r/30920/diff/
Testing
-------
Thanks,
Yan Fang
Re: Review Request 30920: SAMZA-554: Simplify serde configuration by
providing default serde names
Posted by Chris Riccomini <cr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30920/#review72183
-----------------------------------------------------------
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala
<https://reviews.apache.org/r/30920/#comment118188>
Would prefer this being a full-fledged method within `object SamzaContainer`. This will make it easier to unit test.
Also, we should have some unit tests to validate that this works.
- Chris Riccomini
On Feb. 12, 2015, 9:04 a.m., Yan Fang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30920/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2015, 9:04 a.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-554
> https://issues.apache.org/jira/browse/SAMZA-554
>
>
> Repository: samza
>
>
> Description
> -------
>
> provide a method which looks for the serdes in the system when can not find in properties file
>
>
> Diffs
> -----
>
> samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 8a6d865
>
> Diff: https://reviews.apache.org/r/30920/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yan Fang
>
>