[GitHub] rdblue commented on issue #4: Use the same shared FileSystem instance across calls in HadoopTableOperations

[GitBox <gi...@apache.org>]

rdblue commented on issue #4: Use the same shared FileSystem instance across calls in HadoopTableOperations
URL: https://github.com/apache/incubator-iceberg/pull/4#issuecomment-441821155
 
 
   Sorry, I reviewed the copy of this in the Netflix repo: https://github.com/Netflix/iceberg/pull/108
   
   Overall, the change is okay. I think it is fine to expose the factory method as long as it is package-private and only used by HadoopTableOperations. But that really limits the utility of it, while going against best practices for using the Hadoop FS API.
   
   I think the best option for the use case is to subclass HadoopTables & HadoopTableOperations and replace the current behavior if you need to.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services