You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexey Petrenko (JIRA)" <ji...@apache.org> on 2007/07/31 20:56:53 UTC

[jira] Created: (HARMONY-4582) [classlib][swing] JEditorPane does not support
 tag in text/html mode

[classlib][swing] JEditorPane does not support <pre> tag in text/html mode
--------------------------------------------------------------------------

                 Key: HARMONY-4582
                 URL: https://issues.apache.org/jira/browse/HARMONY-4582
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
            Reporter: Alexey Petrenko


JEditorPane does not support <pre> tag: http://www.w3.org/TR/html401/struct/text.html#h-9.3.4

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4582) [classlib][swing] JEditorPane does not support
 tag in text/html mode

Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Petrenko updated HARMONY-4582:
-------------------------------------

    Patch Info: [Patch Available]

> [classlib][swing] JEditorPane does not support <pre> tag in text/html mode
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-4582
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4582
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexey Petrenko
>            Assignee: Alexey Petrenko
>         Attachments: HARMONY-4582-HTMLDocument.patch, HARMONY-4582-HTMLDocument_Reader_ActionsTest.patch, HARMONY-4582-Lexer.patch, Harmony4582Test.java
>
>
> JEditorPane does not support <pre> tag: http://www.w3.org/TR/html401/struct/text.html#h-9.3.4

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-4582) [classlib][swing] JEditorPane does not support
 tag in text/html mode

Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Petrenko closed HARMONY-4582.
------------------------------------

    Resolution: Fixed

Andrey, thanks for the patch. It works fine.

The patch has been applied.

> [classlib][swing] JEditorPane does not support <pre> tag in text/html mode
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-4582
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4582
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexey Petrenko
>            Assignee: Alexey Petrenko
>         Attachments: HARMONY-4582-HTMLDocument.patch, HARMONY-4582-HTMLDocument_Reader_ActionsTest.patch, HARMONY-4582-Lexer.patch, Harmony4582Test.java
>
>
> JEditorPane does not support <pre> tag: http://www.w3.org/TR/html401/struct/text.html#h-9.3.4

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-4582) [classlib][swing] JEditorPane does not support
 tag in text/html mode

Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-4582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519000 ] 

Andrey Pavlenko commented on HARMONY-4582:
------------------------------------------

Alexey, the patches have been applied as expected. Thanks.

> [classlib][swing] JEditorPane does not support <pre> tag in text/html mode
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-4582
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4582
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexey Petrenko
>            Assignee: Alexey Petrenko
>         Attachments: HARMONY-4582-HTMLDocument.patch, HARMONY-4582-HTMLDocument_Reader_ActionsTest.patch, HARMONY-4582-Lexer.patch, Harmony4582Test.java
>
>
> JEditorPane does not support <pre> tag: http://www.w3.org/TR/html401/struct/text.html#h-9.3.4

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-4582) [classlib][swing] JEditorPane does not support
 tag in text/html mode

Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-4582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517454 ] 

Andrey Pavlenko commented on HARMONY-4582:
------------------------------------------

I think you missed HTML tags in your test. I could reproduce the issue with the following test case:

    public void test() {
        JFrame frame = new JFrame("JEditorPane test");
        JEditorPane pane = new JEditorPane("text/html",
                "<html><body><pre>Hello\nworld!</pre></body></html>");
        frame.add(pane);
        frame.pack();
        frame.setVisible(true);
    }

> [classlib][swing] JEditorPane does not support <pre> tag in text/html mode
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-4582
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4582
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexey Petrenko
>         Attachments: HARMONY.JPG, Harmony4582Test.java, RI.JPG
>
>
> JEditorPane does not support <pre> tag: http://www.w3.org/TR/html401/struct/text.html#h-9.3.4

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-4582) [classlib][swing] JEditorPane does not support
 tag in text/html mode

Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Petrenko reassigned HARMONY-4582:
----------------------------------------

    Assignee: Alexey Petrenko

> [classlib][swing] JEditorPane does not support <pre> tag in text/html mode
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-4582
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4582
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexey Petrenko
>            Assignee: Alexey Petrenko
>         Attachments: HARMONY-4582-HTMLDocument.patch, HARMONY-4582-HTMLDocument_Reader_ActionsTest.patch, HARMONY-4582-Lexer.patch, Harmony4582Test.java
>
>
> JEditorPane does not support <pre> tag: http://www.w3.org/TR/html401/struct/text.html#h-9.3.4

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-4582) [classlib][swing] JEditorPane does not support
 tag in text/html mode

Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-4582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517467 ] 

Andrey Pavlenko commented on HARMONY-4582:
------------------------------------------

I see, it was my mistake.

> [classlib][swing] JEditorPane does not support <pre> tag in text/html mode
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-4582
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4582
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexey Petrenko
>         Attachments: Harmony4582Test.java
>
>
> JEditorPane does not support <pre> tag: http://www.w3.org/TR/html401/struct/text.html#h-9.3.4

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4582) [classlib][swing] JEditorPane does not support
 tag in text/html mode

Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Petrenko updated HARMONY-4582:
-------------------------------------

    Attachment:     (was: HARMONY.JPG)

> [classlib][swing] JEditorPane does not support <pre> tag in text/html mode
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-4582
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4582
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexey Petrenko
>         Attachments: Harmony4582Test.java
>
>
> JEditorPane does not support <pre> tag: http://www.w3.org/TR/html401/struct/text.html#h-9.3.4

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4582) [classlib][swing] JEditorPane does not support
 tag in text/html mode

Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Petrenko updated HARMONY-4582:
-------------------------------------

    Attachment: Harmony4582Test.java

Small test case.
The text should be splited in two lines

> [classlib][swing] JEditorPane does not support <pre> tag in text/html mode
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-4582
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4582
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexey Petrenko
>         Attachments: Harmony4582Test.java
>
>
> JEditorPane does not support <pre> tag: http://www.w3.org/TR/html401/struct/text.html#h-9.3.4

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-4582) [classlib][swing] JEditorPane does not support
 tag in text/html mode

Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-4582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517465 ] 

Alexey Petrenko commented on HARMONY-4582:
------------------------------------------

No it does not missed in the test.
I've saved a test as a file and there are all the tags. JIRA has treated this file as html and shows it in browser with formatting, tags are missed in this case.

> [classlib][swing] JEditorPane does not support <pre> tag in text/html mode
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-4582
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4582
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexey Petrenko
>         Attachments: Harmony4582Test.java
>
>
> JEditorPane does not support <pre> tag: http://www.w3.org/TR/html401/struct/text.html#h-9.3.4

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4582) [classlib][swing] JEditorPane does not support
 tag in text/html mode

Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Petrenko updated HARMONY-4582:
-------------------------------------

    Attachment:     (was: RI.JPG)

> [classlib][swing] JEditorPane does not support <pre> tag in text/html mode
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-4582
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4582
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexey Petrenko
>         Attachments: Harmony4582Test.java
>
>
> JEditorPane does not support <pre> tag: http://www.w3.org/TR/html401/struct/text.html#h-9.3.4

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4582) [classlib][swing] JEditorPane does not support
 tag in text/html mode

Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrey Pavlenko updated HARMONY-4582:
-------------------------------------

    Attachment: HARMONY.JPG
                RI.JPG

Alexey, I run your test on RI and Harmony and I do not see any difference. Please, see the attached screen shots.

> [classlib][swing] JEditorPane does not support <pre> tag in text/html mode
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-4582
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4582
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexey Petrenko
>         Attachments: HARMONY.JPG, Harmony4582Test.java, RI.JPG
>
>
> JEditorPane does not support <pre> tag: http://www.w3.org/TR/html401/struct/text.html#h-9.3.4

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4582) [classlib][swing] JEditorPane does not support
 tag in text/html mode

Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrey Pavlenko updated HARMONY-4582:
-------------------------------------

    Attachment: HARMONY-4582-HTMLDocument_Reader_ActionsTest.patch
                HARMONY-4582-HTMLDocument.patch
                HARMONY-4582-Lexer.patch

There are 2 issues: the first one is in the Lexer which loses one of the line separators following one by one; the second one is in the HTML content handler which does not handle content inside <pre> tags.
The attached patches fix the issues.

> [classlib][swing] JEditorPane does not support <pre> tag in text/html mode
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-4582
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4582
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexey Petrenko
>         Attachments: HARMONY-4582-HTMLDocument.patch, HARMONY-4582-HTMLDocument_Reader_ActionsTest.patch, HARMONY-4582-Lexer.patch, Harmony4582Test.java
>
>
> JEditorPane does not support <pre> tag: http://www.w3.org/TR/html401/struct/text.html#h-9.3.4

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.