You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/13 15:38:45 UTC
[GitHub] [flink] KarmaGYZ commented on a change in pull request #10571: [FLINK-15241] Revert the unexpected change of the configuration for M…
KarmaGYZ commented on a change in pull request #10571: [FLINK-15241] Revert the unexpected change of the configuration for M…
URL: https://github.com/apache/flink/pull/10571#discussion_r357703361
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtils.java
##########
@@ -570,7 +570,7 @@ private static CPUResource getCpuCores(final Configuration config, double fallba
if (cpuCores < 0) {
throw new IllegalConfigurationException("Configured cpu cores must be non-negative.");
}
- } else if (fallback >= 0.0) {
Review comment:
Thanks for the review @tillrohrmann . True, changing the default of MESOS_RM_TASKS_CPUS to a negative value is another way. However, I don't get the meaning of requiring 0 cores. It seems to be an invalid value. Could @xintongsong kindly help to clarify this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services