svn commit: r1056750 - in /commons/proper/lang/branches/LANG_2_X: checkstyle.xml pom.xml

[ni...@apache.org]

Author: niallp
Date: Sat Jan  8 18:30:55 2011
New Revision: 1056750

URL: http://svn.apache.org/viewvc?rev=1056750&view=rev
Log:
Add findbugs and test coverage and upgrade checkstyle

Modified:
    commons/proper/lang/branches/LANG_2_X/checkstyle.xml
    commons/proper/lang/branches/LANG_2_X/pom.xml

Modified: commons/proper/lang/branches/LANG_2_X/checkstyle.xml
URL: http://svn.apache.org/viewvc/commons/proper/lang/branches/LANG_2_X/checkstyle.xml?rev=1056750&r1=1056749&r2=1056750&view=diff
==============================================================================
--- commons/proper/lang/branches/LANG_2_X/checkstyle.xml (original)
+++ commons/proper/lang/branches/LANG_2_X/checkstyle.xml Sat Jan  8 18:30:55 2011
@@ -23,9 +23,14 @@ limitations under the License.
 <!-- commons lang customization of default Checkstyle behavior -->
 <module name="Checker">
   <property name="localeLanguage" value="en"/>
-  <module name="PackageHtml"/>
+  <module name="JavadocPackage">
+    <!-- setting allowLegacy means it will check for package.html instead of just package-info.java -->
+    <property name="allowLegacy" value="true"/>
+  </module>
+  <module name="FileTabCharacter">
+    <property name="fileExtensions" value="java,xml"/>
+  </module>
   <module name="TreeWalker">
-    <module name="TabCharacter"/>
     <module name="AvoidStarImport"/>
     <module name="RedundantImport"/>
     <module name="UnusedImports"/>

Modified: commons/proper/lang/branches/LANG_2_X/pom.xml
URL: http://svn.apache.org/viewvc/commons/proper/lang/branches/LANG_2_X/pom.xml?rev=1056750&r1=1056749&r2=1056750&view=diff
==============================================================================
--- commons/proper/lang/branches/LANG_2_X/pom.xml (original)
+++ commons/proper/lang/branches/LANG_2_X/pom.xml Sat Jan  8 18:30:55 2011
@@ -22,7 +22,7 @@
   <parent>
     <groupId>org.apache.commons</groupId>
     <artifactId>commons-parent</artifactId>
-    <version>15</version>
+    <version>17</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
   <groupId>commons-lang</groupId>
@@ -505,17 +505,17 @@
         </plugin>
       <plugin>
         <artifactId>maven-checkstyle-plugin</artifactId>
-        <version>2.3</version>
+        <version>2.6</version>
         <configuration>
           <configLocation>${basedir}/checkstyle.xml</configLocation>
           <enableRulesSummary>false</enableRulesSummary>
         </configuration>
       </plugin>
-      <!--
+      <!-- Requires setting 'export MAVEN_OPTS="-Xmx512m" ' -->
       <plugin>
         <groupId>org.codehaus.mojo</groupId>
         <artifactId>findbugs-maven-plugin</artifactId>
-        <version>1.2</version>
+        <version>2.3.1</version>
         <configuration>
           <threshold>Normal</threshold>
           <effort>Default</effort>
@@ -524,9 +524,8 @@
       <plugin>
         <groupId>org.codehaus.mojo</groupId>
         <artifactId>cobertura-maven-plugin</artifactId>
-        <version>2.3</version>
+        <version>2.4</version>
       </plugin>
-      -->
       <plugin>
         <groupId>org.codehaus.mojo</groupId>
         <artifactId>clirr-maven-plugin</artifactId>