You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/10/11 11:31:26 UTC

[GitHub] [iceberg] pvary commented on a change in pull request #3252: Hive: Add tests for HiveCatalog no-arg constructor, setConf, and initialize

pvary commented on a change in pull request #3252:
URL: https://github.com/apache/iceberg/pull/3252#discussion_r726033217



##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -95,6 +95,10 @@ public HiveCatalog(Configuration conf) {
   @Override
   public void initialize(String inputName, Map<String, String> properties) {
     this.name = inputName;
+    if (this.conf == null){

Review comment:
       nit: space after `(`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org