You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "jgruenberger (via GitHub)" <gi...@apache.org> on 2023/09/05 13:24:35 UTC

[GitHub] [cordova-plugin-inappbrowser] jgruenberger opened a new pull request, #1018: Android: add try catch around dialog.dismiss() to prevent crashes

jgruenberger opened a new pull request, #1018:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/1018

   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   
   
   ### Description
   <!-- Describe your changes in detail -->
   
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

Re: [PR] Android: add try catch around dialog.dismiss() to prevent crashes [cordova-plugin-inappbrowser]

Posted by "platov (via GitHub)" <gi...@apache.org>.
platov commented on PR #1018:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/1018#issuecomment-2043342765

   @jgruenberger , will this PR be merged?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

Re: [PR] Android: add try catch around dialog.dismiss() to prevent crashes [cordova-plugin-inappbrowser]

Posted by "aliyafthh (via GitHub)" <gi...@apache.org>.
aliyafthh commented on PR #1018:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/1018#issuecomment-2121841159

   Hi, can i know when this PR will be merged?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-inappbrowser] jgruenberger commented on pull request #1018: Android: add try catch around dialog.dismiss() to prevent crashes

Posted by "jgruenberger (via GitHub)" <gi...@apache.org>.
jgruenberger commented on PR #1018:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/1018#issuecomment-1706623915

   We are getting app crashes from InAppBrowser on Crashlytics. This try catch claused resolved the issue. 
   
   Resolves #470
   Resolves #893
   Resolves #1007


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

Re: [PR] Android: add try catch around dialog.dismiss() to prevent crashes [cordova-plugin-inappbrowser]

Posted by "jgruenberger (via GitHub)" <gi...@apache.org>.
jgruenberger commented on PR #1018:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/1018#issuecomment-2043353590

   Hi @platov,
   
   i created the PR and hope the owner of the repo will merge it....
   
   Best,
   Juergen


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org