You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "FMX (via GitHub)" <gi...@apache.org> on 2024/01/02 08:53:03 UTC
[PR] [CELEBORN-1205] fix sbt build failure [incubator-celeborn]
FMX opened a new pull request, #2199:
URL: https://github.com/apache/incubator-celeborn/pull/2199
### What changes were proposed in this pull request?
To eliminate build failure when using SBT.
### Why are the changes needed?
If the maven local cache is enabled, SBT can't find the correct dependencies.
If the maven local cache is disabled, SBT can find the correct dependencies.
### Does this PR introduce _any_ user-facing change?
NO
### How was this patch tested?
GA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1205] Disable Maven local caches to improve SBT building stability [incubator-celeborn]
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #2199: [CELEBORN-1205] Disable Maven local caches to improve SBT building stability
URL: https://github.com/apache/incubator-celeborn/pull/2199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1205] Disable Maven local caches to improve SBT building stability [incubator-celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2199:
URL: https://github.com/apache/incubator-celeborn/pull/2199#issuecomment-1873763054
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2199?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`ecd577e`)](https://app.codecov.io/gh/apache/incubator-celeborn/commit/ecd577e5d3944b7e15aa5a9930b9013119f932f8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 47.08% compared to head [(`962d090`)](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2199?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 47.11%.
> :exclamation: Current head 962d090 differs from pull request most recent head 74467fc. Consider uploading reports for the commit 74467fc to get more accurate results
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2199 +/- ##
==========================================
+ Coverage 47.08% 47.11% +0.03%
==========================================
Files 185 185
Lines 11706 11706
Branches 1043 1043
==========================================
+ Hits 5511 5514 +3
+ Misses 5825 5824 -1
+ Partials 370 368 -2
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2199?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1205] Disable Maven local caches to improve SBT building stability [incubator-celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #2199:
URL: https://github.com/apache/incubator-celeborn/pull/2199#issuecomment-1873813993
+1 for disable Maven cache by default.
There seems an issue that SBT treats a Maven `.m2` cache as valid when only `pom.xml` is present but `xxx.jar` absent, then causes the building failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org