You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by aweisberg <gi...@git.apache.org> on 2018/02/09 22:39:22 UTC
[GitHub] cassandra pull request #193: Better document in code InetAddressAndPort usag...
GitHub user aweisberg opened a pull request:
https://github.com/apache/cassandra/pull/193
Better document in code InetAddressAndPort usage post 7544
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aweisberg/cassandra cassandra-14226
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cassandra/pull/193.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #193
----
commit 477a4e29d7a331a1175b25ad91061cba30d08e23
Author: Ariel Weisberg <aw...@...>
Date: 2018-02-09T22:38:52Z
Better document in code InetAddressAndPort usage post 7544
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] cassandra pull request #193: Better document in code InetAddressAndPort usag...
Posted by aweisberg <gi...@git.apache.org>.
Github user aweisberg commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/193#discussion_r167605713
--- Diff: src/java/org/apache/cassandra/config/Config.java ---
@@ -128,6 +128,13 @@
public boolean listen_on_broadcast_address = false;
public String internode_authenticator;
+ /*
+ * RPC address and interface refer to the address/interface used for the native protocol used to communicate with
+ * clients. It's still called RPC in some places even though Thrift RPC is gone. If you see references to native
+ * address or native port it's dervied from the RPC address configuration.
--- End diff --
Fixed thanks.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] cassandra pull request #193: Better document in code InetAddressAndPort usag...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cassandra/pull/193
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] cassandra pull request #193: Better document in code InetAddressAndPort usag...
Posted by rhardouin <gi...@git.apache.org>.
Github user rhardouin commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/193#discussion_r167497215
--- Diff: src/java/org/apache/cassandra/config/Config.java ---
@@ -128,6 +128,13 @@
public boolean listen_on_broadcast_address = false;
public String internode_authenticator;
+ /*
+ * RPC address and interface refer to the address/interface used for the native protocol used to communicate with
+ * clients. It's still called RPC in some places even though Thrift RPC is gone. If you see references to native
+ * address or native port it's dervied from the RPC address configuration.
--- End diff --
Small typo `s/dervied/derived`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org