You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/12/10 01:08:50 UTC

Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40382/
-----------------------------------------------------------

(Updated Dec. 10, 2015, 12:08 a.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.


Repository: mesos


Description
-------

Windows: Added threadsafe `strerror_r` implementaiton.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp 71689089a7818e3465e7e51becc43c7836b67240 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027 

Diff: https://reviews.apache.org/r/40382/diff/


Testing
-------


Thanks,

Alex Clemmer


Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40382/#review109652
-----------------------------------------------------------

Ship it!


Ship It!

- Joris Van Remoortere


On Dec. 10, 2015, 1:06 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40382/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2015, 1:06 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-4107
>     https://issues.apache.org/jira/browse/MESOS-4107
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Added threadsafe `strerror_r` implementaiton.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp 71689089a7818e3465e7e51becc43c7836b67240 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027 
> 
> Diff: https://reviews.apache.org/r/40382/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation.

Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40382/
-----------------------------------------------------------

(Updated Dec. 10, 2015, 1:06 a.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.


Bugs: MESOS-4107
    https://issues.apache.org/jira/browse/MESOS-4107


Repository: mesos


Description
-------

Windows: Added threadsafe `strerror_r` implementaiton.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp 71689089a7818e3465e7e51becc43c7836b67240 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027 

Diff: https://reviews.apache.org/r/40382/diff/


Testing
-------


Thanks,

Alex Clemmer