You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/02/12 21:54:47 UTC

[kudu-CR](branch-1.9.x) KUDU-2411: fix dep pattern matching in relocation script

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12460


Change subject: KUDU-2411: fix dep pattern matching in relocation script
......................................................................

KUDU-2411: fix dep pattern matching in relocation script

The trailing '|' caused all shared objects except for the sasl2 modules to
be excluded. The resulting archive wasn't usable.

Change-Id: If90f95bd7a1a8f8c2a3f6441d047096542f1f048
---
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/12460/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12460
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: If90f95bd7a1a8f8c2a3f6441d047096542f1f048
Gerrit-Change-Number: 12460
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>

[kudu-CR](branch-1.9.x) KUDU-2411: fix dep pattern matching in relocation script

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12460 )

Change subject: KUDU-2411: fix dep pattern matching in relocation script
......................................................................

KUDU-2411: fix dep pattern matching in relocation script

The trailing '|' caused all shared objects except for the sasl2 modules to
be excluded. The resulting archive wasn't usable.

Change-Id: If90f95bd7a1a8f8c2a3f6441d047096542f1f048
Reviewed-on: http://gerrit.cloudera.org:8080/12460
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/12460
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: merged
Gerrit-Change-Id: If90f95bd7a1a8f8c2a3f6441d047096542f1f048
Gerrit-Change-Number: 12460
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.9.x) KUDU-2411: fix dep pattern matching in relocation script

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12460 )

Change subject: KUDU-2411: fix dep pattern matching in relocation script
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12460
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: comment
Gerrit-Change-Id: If90f95bd7a1a8f8c2a3f6441d047096542f1f048
Gerrit-Change-Number: 12460
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 12 Feb 2019 23:11:52 +0000
Gerrit-HasComments: No