You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/13 21:47:44 UTC

[GitHub] [spark] huaxingao commented on a change in pull request #33739: [SPARK-34952][SQL][FOLLOWUP] Normalize pushed down aggregate col name and group by col name

huaxingao commented on a change in pull request #33739:
URL: https://github.com/apache/spark/pull/33739#discussion_r688795967



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala
##########
@@ -93,8 +93,12 @@ object V2ScanRelationPushDown extends Rule[LogicalPlan] with PredicateHelper {
                     agg
                 }
               }
+              aggregates = DataSourceStrategy.normalizeExprs(aggregates, sHolder.relation.output)

Review comment:
       Done. Thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org