[jira] [Commented] (AIRFLOW-5658) Links issue through reverse proxy access

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16997811#comment-16997811 ] 

ASF subversion and git services commented on AIRFLOW-5658:
----------------------------------------------------------

Commit c883e38c79bf9f757909764767e7dbac6517223d in airflow's branch refs/heads/v1-10-test from Oluwafemi Sule
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=c883e38 ]

[AIRFLOW-5658] Fix broken navigation links (#6374)

Configuration and Version links are broken when running airflow
behind reverse proxy.

Registering navigation links through their respective views
ensure that correct links are rendered in the menu.


> Links issue through reverse proxy access 
> -----------------------------------------
>
>                 Key: AIRFLOW-5658
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5658
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: ui
>    Affects Versions: 1.10.4, 1.10.5
>            Reporter: Mikołaj Morawski
>            Assignee: Oluwafemi Sule
>            Priority: Trivial
>             Fix For: 1.10.7
>
>         Attachments: image-2019-10-15-16-02-45-731.png
>
>
> The access through a reverse proxy is not working for the following two uris:
> /configuration
> /version
>  
> I think that the root cause is here:
> [https://github.com/apache/airflow/blob/master/airflow/www/app.py]
> {code:java}
>             appbuilder.add_link("Configurations",
>                                 href='/configuration',
>                                 category="Admin",
>                                 category_icon="fa-user")
>             appbuilder.add_link('Version',
>                                 href='/version',
>                                 category='About',
>                                 category_icon='fa-th')
> {code}
>  the "href" parameter does not use the "views" reference here. The add_link should not be used for this reference.  
>  
>  The second problem is that the "Task Tries" icon is not displayed properly. 
>   !image-2019-10-15-16-02-45-731.png!
> Regards,
> Mikolaj 
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)