You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "imply-elliott (via GitHub)" <gi...@apache.org> on 2023/03/02 22:28:13 UTC
[GitHub] [druid] imply-elliott opened a new pull request, #13878: Bump CycloneDX module to address POM errors
imply-elliott opened a new pull request, #13878:
URL: https://github.com/apache/druid/pull/13878
### Description
- CycloneDX 2.7.5 does not cause the same `error [ERROR] An error occurred attempting to read POM` errors that we were seeing.
This PR has:
- [x] been self-reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers commented on a diff in pull request #13878: Bump CycloneDX module to address POM errors
Posted by "paul-rogers (via GitHub)" <gi...@apache.org>.
paul-rogers commented on code in PR #13878:
URL: https://github.com/apache/druid/pull/13878#discussion_r1123974232
##########
.github/workflows/standard-its.yml:
##########
@@ -106,9 +106,7 @@ jobs:
runs-on: ubuntu-22.04
env:
MVN: mvn --no-snapshot-updates
- # Added -Dcyclonedx.skip=true to avoid ISO-8859-1 [ERROR]s
- # May be fixed in the future
- MAVEN_SKIP: -P skip-static-checks -Dweb.console.skip=true -Dmaven.javadoc.skip=true -Dcyclonedx.skip=true
+ MAVEN_SKIP: -P skip-static-checks -Dweb.console.skip=true -Dmaven.javadoc.skip=true
Review Comment:
Can also skip CycloneDX for the standard ITs since we do it for the build. It doesn't add much to repeat it for the ITs as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers commented on a diff in pull request #13878: Bump CycloneDX module to address POM errors
Posted by "paul-rogers (via GitHub)" <gi...@apache.org>.
paul-rogers commented on code in PR #13878:
URL: https://github.com/apache/druid/pull/13878#discussion_r1123974232
##########
.github/workflows/standard-its.yml:
##########
@@ -106,9 +106,7 @@ jobs:
runs-on: ubuntu-22.04
env:
MVN: mvn --no-snapshot-updates
- # Added -Dcyclonedx.skip=true to avoid ISO-8859-1 [ERROR]s
- # May be fixed in the future
- MAVEN_SKIP: -P skip-static-checks -Dweb.console.skip=true -Dmaven.javadoc.skip=true -Dcyclonedx.skip=true
+ MAVEN_SKIP: -P skip-static-checks -Dweb.console.skip=true -Dmaven.javadoc.skip=true
Review Comment:
Comments are out of order. Can also skip CycloneDX for the standard ITs since we do it for the build. It doesn't add much to repeat it for the ITs as well.
##########
it.sh:
##########
@@ -193,9 +193,7 @@ fi
CMD=$1
shift
-# Added -Dcyclonedx.skip=true to avoid ISO-8859-1 [ERROR]s
-# May be fixed in the future
-MAVEN_IGNORE="-P skip-static-checks,skip-tests -Dmaven.javadoc.skip=true -Dcyclonedx.skip=true"
+MAVEN_IGNORE="-P skip-static-checks,skip-tests -Dmaven.javadoc.skip=true"
Review Comment:
This one can remain since we don't need to repeat the checks for the ITs. No worries; I'll add it in a different PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 merged pull request #13878: Bump CycloneDX module to address POM errors
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 merged PR #13878:
URL: https://github.com/apache/druid/pull/13878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on pull request #13878: Bump CycloneDX module to address POM errors
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 commented on PR #13878:
URL: https://github.com/apache/druid/pull/13878#issuecomment-1453283017
Merging this since it was causing all builds to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] imply-elliott commented on pull request #13878: Bump CycloneDX module to address POM errors
Posted by "imply-elliott (via GitHub)" <gi...@apache.org>.
imply-elliott commented on PR #13878:
URL: https://github.com/apache/druid/pull/13878#issuecomment-1452684409
>
> Thanks for tackling this @imply-elliott. Can we also revert the same workaround change made in the web-console project: #13874?
Certainly, will update the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org