You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Laszlo Gaal (Code Review)" <ge...@cloudera.org> on 2024/03/11 21:12:09 UTC
[native-toolchain-CR] IMPALA-12885: Log configuration values when starting a toolchain build
Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21135
Change subject: IMPALA-12885: Log configuration values when starting a toolchain build
......................................................................
IMPALA-12885: Log configuration values when starting a toolchain build
Report the main environment variables before the build starts, in a way
similar to what happens at the end of Impala's bin/impala-config.sh
Change-Id: Ie6549bb01acce51771fb796c89826b6bbdc54494
---
M init.sh
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/35/21135/1
--
To view, visit http://gerrit.cloudera.org:8080/21135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6549bb01acce51771fb796c89826b6bbdc54494
Gerrit-Change-Number: 21135
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
[native-toolchain-CR] IMPALA-12885: Log configuration values when starting a toolchain build
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21135 )
Change subject: IMPALA-12885: Log configuration values when starting a toolchain build
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21135/1/init.sh
File init.sh:
http://gerrit.cloudera.org:8080/#/c/21135/1/init.sh@208
PS1, Line 208: echo "PRODUCTION = ${PRODUCTION}"
> Curious, why does this get curly braces?
IIRC that was the first variable I added, the rest was added in a second step. IOW pure inconsistency; I'll upload a fix.
--
To view, visit http://gerrit.cloudera.org:8080/21135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6549bb01acce51771fb796c89826b6bbdc54494
Gerrit-Change-Number: 21135
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Mar 2024 22:10:59 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-12885: Log configuration values when starting a toolchain build
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21135
to look at the new patch set (#2).
Change subject: IMPALA-12885: Log configuration values when starting a toolchain build
......................................................................
IMPALA-12885: Log configuration values when starting a toolchain build
Report the main environment variables before the build starts, in a way
similar to what happens at the end of Impala's bin/impala-config.sh
Change-Id: Ie6549bb01acce51771fb796c89826b6bbdc54494
---
M init.sh
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/35/21135/2
--
To view, visit http://gerrit.cloudera.org:8080/21135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie6549bb01acce51771fb796c89826b6bbdc54494
Gerrit-Change-Number: 21135
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-12885: Log configuration values when starting a toolchain build
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21135 )
Change subject: IMPALA-12885: Log configuration values when starting a toolchain build
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21135/1/init.sh
File init.sh:
http://gerrit.cloudera.org:8080/#/c/21135/1/init.sh@208
PS1, Line 208: echo "PRODUCTION = $PRODUCTION"
> IIRC that was the first variable I added, the rest was added in a second st
Done
--
To view, visit http://gerrit.cloudera.org:8080/21135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6549bb01acce51771fb796c89826b6bbdc54494
Gerrit-Change-Number: 21135
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Mar 2024 22:13:00 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-12885: Log configuration values when starting a toolchain build
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21135 )
Change subject: IMPALA-12885: Log configuration values when starting a toolchain build
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6549bb01acce51771fb796c89826b6bbdc54494
Gerrit-Change-Number: 21135
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Mar 2024 22:26:53 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-12885: Log configuration values when starting a toolchain build
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21135 )
Change subject: IMPALA-12885: Log configuration values when starting a toolchain build
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21135/1/init.sh
File init.sh:
http://gerrit.cloudera.org:8080/#/c/21135/1/init.sh@208
PS1, Line 208: echo "PRODUCTION = ${PRODUCTION}"
Curious, why does this get curly braces?
--
To view, visit http://gerrit.cloudera.org:8080/21135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6549bb01acce51771fb796c89826b6bbdc54494
Gerrit-Change-Number: 21135
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Mar 2024 21:13:48 +0000
Gerrit-HasComments: Yes