You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "codelipenghui (via GitHub)" <gi...@apache.org> on 2024/05/17 13:37:36 UTC
[PR] [branch-3.0][feat][broker] Implementation of PIP-323: Complete Backlog Quota Telemetry (#21816) [pulsar]
codelipenghui opened a new pull request, #22740:
URL: https://github.com/apache/pulsar/pull/22740
(cherry picked from commit 59782b3c1f63baa68b2f5f33a33f1b00212159d7)
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [branch-3.0][feat][broker] Implementation of PIP-323: Complete Backlog Quota Telemetry (#21816) [pulsar]
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #22740:
URL: https://github.com/apache/pulsar/pull/22740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [branch-3.0][feat][broker] Implementation of PIP-323: Complete Backlog Quota Telemetry (#21816) [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #22740:
URL: https://github.com/apache/pulsar/pull/22740#discussion_r1605194713
##########
pulsar-broker/pom.xml:
##########
@@ -417,6 +417,12 @@
<artifactId>javax.activation</artifactId>
</dependency>
+ <dependency>
+ <groupId>io.rest-assured</groupId>
+ <artifactId>rest-assured</artifactId>
+ <scope>test</scope>
+ </dependency>
+
Review Comment:
btw. I `../pom.xml` is the default. We should be removing the outdated `<relativePath>..</relativePath>` entries completely.
there's `<xs:element minOccurs="0" name="relativePath" type="xs:string" default="../pom.xml">` in the `maven-4.0.0.xsd` which shows the default.
##########
pulsar-broker/pom.xml:
##########
@@ -417,6 +417,12 @@
<artifactId>javax.activation</artifactId>
</dependency>
+ <dependency>
+ <groupId>io.rest-assured</groupId>
+ <artifactId>rest-assured</artifactId>
+ <scope>test</scope>
+ </dependency>
+
Review Comment:
btw. `../pom.xml` is the default. We should be removing the outdated `<relativePath>..</relativePath>` entries completely.
there's `<xs:element minOccurs="0" name="relativePath" type="xs:string" default="../pom.xml">` in the `maven-4.0.0.xsd` which shows the default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [branch-3.0][feat][broker] Implementation of PIP-323: Complete Backlog Quota Telemetry (#21816) [pulsar]
Posted by "codelipenghui (via GitHub)" <gi...@apache.org>.
codelipenghui commented on code in PR #22740:
URL: https://github.com/apache/pulsar/pull/22740#discussion_r1605057473
##########
pulsar-broker/pom.xml:
##########
@@ -417,6 +417,12 @@
<artifactId>javax.activation</artifactId>
</dependency>
+ <dependency>
+ <groupId>io.rest-assured</groupId>
+ <artifactId>rest-assured</artifactId>
+ <scope>test</scope>
+ </dependency>
+
Review Comment:
It's not required and I think we also need to change the master branch to make it consistent as other components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [branch-3.0][feat][broker] Implementation of PIP-323: Complete Backlog Quota Telemetry (#21816) [pulsar]
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- commented on code in PR #22740:
URL: https://github.com/apache/pulsar/pull/22740#discussion_r1605046858
##########
pulsar-broker/pom.xml:
##########
@@ -417,6 +417,12 @@
<artifactId>javax.activation</artifactId>
</dependency>
+ <dependency>
+ <groupId>io.rest-assured</groupId>
+ <artifactId>rest-assured</artifactId>
+ <scope>test</scope>
+ </dependency>
+
Review Comment:
I see the origin patch has another fix at line 29.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [branch-3.0][feat][broker] Implementation of PIP-323: Complete Backlog Quota Telemetry (#21816) [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #22740:
URL: https://github.com/apache/pulsar/pull/22740#discussion_r1605205281
##########
pulsar-broker/pom.xml:
##########
@@ -417,6 +417,12 @@
<artifactId>javax.activation</artifactId>
</dependency>
+ <dependency>
+ <groupId>io.rest-assured</groupId>
+ <artifactId>rest-assured</artifactId>
+ <scope>test</scope>
+ </dependency>
+
Review Comment:
created https://github.com/apache/pulsar/pull/22741 to cover the pom.xml files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [branch-3.0][feat][broker] Implementation of PIP-323: Complete Backlog Quota Telemetry (#21816) [pulsar]
Posted by "codelipenghui (via GitHub)" <gi...@apache.org>.
codelipenghui commented on PR #22740:
URL: https://github.com/apache/pulsar/pull/22740#issuecomment-2117629867
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org