[GitHub] [spark] maryannxue commented on a change in pull request #24653: [SPARK-27783][SQL] Add customizable hint error handler

[GitBox <gi...@apache.org>]

maryannxue commented on a change in pull request #24653: [SPARK-27783][SQL] Add customizable hint error handler
URL: https://github.com/apache/spark/pull/24653#discussion_r287048379
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala
 ##########
 @@ -74,11 +76,13 @@ object ResolveHints {
           case ResolvedHint(u: UnresolvedRelation, hint)
               if relations.exists(resolver(_, u.tableIdentifier.table)) =>
             relations.remove(u.tableIdentifier.table)
-            ResolvedHint(u, createHintInfo(hintName).merge(hint, handleOverriddenHintInfo))
+            ResolvedHint(u,
+              createHintInfo(hintName).merge(hint, hintErrorHandler.handleHintOverridden))
 
 Review comment:
   Yeah, that makes sense.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org