[GitHub] [hadoop] YuanbenWang commented on a diff in pull request #5520: HDFS-16965. Add switch to decide whether to enable native codec.

["YuanbenWang (via GitHub)" <gi...@apache.org>]

YuanbenWang commented on code in PR #5520:
URL: https://github.com/apache/hadoop/pull/5520#discussion_r1187104682


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/CodecUtil.java:
##########
@@ -170,8 +174,14 @@ private static String[] getRawCoderNames(
 
   private static RawErasureEncoder createRawEncoderWithFallback(
       Configuration conf, String codecName, ErasureCoderOptions coderOptions) {
+    boolean ISALEnabled = conf.getBoolean(IO_ERASURECODE_CODEC_NATIVE_ENABLED_KEY,
+        IO_ERASURECODE_CODEC_NATIVE_ENABLED_DEFAULT);
     String[] rawCoderNames = getRawCoderNames(conf, codecName);
     for (String rawCoderName : rawCoderNames) {
+      if (!ISALEnabled && rawCoderName.contains("native")) {
+        LOG.info("Disable the encoder with ISA-L.");

Review Comment:
   @cnauroth Thank you for your suggestion. I'v updated the code and changed the log level to debug. Could you review this please?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org