[jira] [Commented] (LUCENE-10400) Clean up the constructors' API signature of dictionary classes in kuromoji and nori

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-10400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488015#comment-17488015 ] 

ASF subversion and git services commented on LUCENE-10400:
----------------------------------------------------------

Commit e7546c2427e9b82eb4a4632a992866e5436d97a4 in lucene's branch refs/heads/main from Tomoko Uchida
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=e7546c2 ]

LUCENE-10400: revise binary dictionaries' constructor in kuromoji (#643)



> Clean up the constructors' API signature of dictionary classes in kuromoji and nori
> -----------------------------------------------------------------------------------
>
>                 Key: LUCENE-10400
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10400
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/analysis
>            Reporter: Tomoko Uchida
>            Priority: Major
>          Time Spent: 7.5h
>  Remaining Estimate: 0h
>
> It was suggested in a few issues/pr comments.
>  * do not delegate to load class resources to other classes
>  * do not allow to switch the location (classpath/file path) of the resource by constructor parameter
> Before working on LUCENE-8816 or LUCENE-10393, we'd need to sort the protected constructor APIs.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org