You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by wu...@apache.org on 2019/04/09 06:59:30 UTC
[incubator-skywalking] branch optional-trace-analysis created (now
241595a)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch optional-trace-analysis
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git.
at 241595a Support shutdown the trace analysis.
This branch includes the following new commits:
new 241595a Support shutdown the trace analysis.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[incubator-skywalking] 01/01: Support shutdown the trace analysis.
Posted by wu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch optional-trace-analysis
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git
commit 241595a3698c5efb554a67c65d67eae190056fd8
Author: Wu Sheng <wu...@foxmail.com>
AuthorDate: Tue Apr 9 14:59:20 2019 +0800
Support shutdown the trace analysis.
---
.../server/receiver/trace/provider/TraceModuleProvider.java | 12 ++++++++----
.../receiver/trace/provider/TraceServiceModuleConfig.java | 8 ++++++++
2 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/TraceModuleProvider.java b/oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/TraceModuleProvider.java
index e346503..a47ec32 100644
--- a/oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/TraceModuleProvider.java
+++ b/oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/TraceModuleProvider.java
@@ -63,15 +63,19 @@ public class TraceModuleProvider extends ModuleProvider {
moduleConfig.setDbLatencyThresholds(new DBLatencyThresholds(moduleConfig.getSlowDBAccessThreshold()));
SegmentParserListenerManager listenerManager = new SegmentParserListenerManager();
- listenerManager.add(new MultiScopesSpanListener.Factory());
- listenerManager.add(new ServiceMappingSpanListener.Factory());
+ if (moduleConfig.isTraceAnalysis()) {
+ listenerManager.add(new MultiScopesSpanListener.Factory());
+ listenerManager.add(new ServiceMappingSpanListener.Factory());
+ }
listenerManager.add(new SegmentSpanListener.Factory(moduleConfig.getSampleRate()));
segmentProducer = new SegmentParse.Producer(getManager(), listenerManager, moduleConfig);
listenerManager = new SegmentParserListenerManager();
- listenerManager.add(new MultiScopesSpanListener.Factory());
- listenerManager.add(new ServiceMappingSpanListener.Factory());
+ if (moduleConfig.isTraceAnalysis()) {
+ listenerManager.add(new MultiScopesSpanListener.Factory());
+ listenerManager.add(new ServiceMappingSpanListener.Factory());
+ }
listenerManager.add(new SegmentSpanListener.Factory(moduleConfig.getSampleRate()));
segmentProducerV2 = new SegmentParseV2.Producer(getManager(), listenerManager, moduleConfig);
diff --git a/oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/TraceServiceModuleConfig.java b/oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/TraceServiceModuleConfig.java
index 8ebeec6..fce1ca7 100644
--- a/oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/TraceServiceModuleConfig.java
+++ b/oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/TraceServiceModuleConfig.java
@@ -39,4 +39,12 @@ public class TraceServiceModuleConfig extends ModuleConfig {
*/
@Setter @Getter private String slowDBAccessThreshold = "default:200";
@Setter @Getter private DBLatencyThresholds dbLatencyThresholds;
+ /**
+ * Analysis trace status.
+ *
+ * 1. Default(YES) means analysis all metric from trace.
+ *
+ * 2. NO means, only save trace, but metrics come other places, such as service mesh.
+ */
+ @Setter @Getter private boolean traceAnalysis = true;
}