[GitHub] [skywalking-nodejs] michaelzangl opened a new pull request, #94: Ignore no requests if ignoreSuffix is empty

[GitBox <gi...@apache.org>]

michaelzangl opened a new pull request, #94:
URL: https://github.com/apache/skywalking-nodejs/pull/94

   An empty ignore suffix currently causes all requests to be ignored. This makes it impossible to disable ignoring by suffix.
   
   I could not find any test testing this regexp / other config stuff, so I did not write a test for my change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-nodejs] tkNobug commented on pull request #94: Ignore no requests if ignoreSuffix is empty

[GitBox <gi...@apache.org>]

tkNobug commented on PR #94:
URL: https://github.com/apache/skywalking-nodejs/pull/94#issuecomment-1271319999

   这是来自QQ邮箱的假期自动回复邮件。您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-nodejs] kezhenxu94 merged pull request #94: Ignore no requests if ignoreSuffix is empty

[GitBox <gi...@apache.org>]

kezhenxu94 merged PR #94:
URL: https://github.com/apache/skywalking-nodejs/pull/94


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org