You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "chenjinbao1989 (via GitHub)" <gi...@apache.org> on 2026/10/15 04:27:46 UTC
[PR] Test the flaky tests [cloudberry]
chenjinbao1989 opened a new pull request, #2133:
URL: https://github.com/apache/cloudberry/pull/2133
<!-- Thank you for your contribution to Apache Cloudberry (Incubating)! -->
Fixes #ISSUE_Number
### What does this PR do?
<!-- Brief overview of the changes, including any major features or fixes -->
### Type of Change
- [ ] Bug fix (non-breaking change)
- [ ] New feature (non-breaking change)
- [ ] Breaking change (fix or feature with breaking changes)
- [ ] Documentation update
### Breaking Changes
<!-- Remove if not applicable. If yes, explain impact and migration path -->
### Test Plan
<!-- How did you test these changes? -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Passed `make installcheck`
- [ ] Passed `make -C src/test installcheck-cbdb-parallel`
### Impact
<!-- Remove sections that don't apply -->
**Performance:**
<!-- Any performance implications? -->
**User-facing changes:**
<!-- Any changes visible to users? -->
**Dependencies:**
<!-- New dependencies or version changes? -->
### Checklist
- [ ] Followed [contribution guide](https://cloudberry.apache.org/contribute/code)
- [ ] Added/updated documentation
- [ ] Reviewed code for security implications
- [ ] This PR contains AI-assisted code generation
- [ ] Requested review from [cloudberry committers](https://github.com/orgs/apache/teams/cloudberry-committers)
### Additional Context
<!-- Any other information that would help reviewers? Remove if none -->
### CI Skip Instructions
<!--
To skip CI builds, add the appropriate CI skip identifier to your PR title.
The identifier must:
- Be in square brackets []
- Include the word "ci" and either "skip" or "no"
- Only use for documentation-only changes or when absolutely necessary
-->
---
<!-- Join our community:
- Mailing list: [dev@cloudberry.apache.org](https://lists.apache.org/list.html?dev@cloudberry.apache.org) (subscribe: dev-subscribe@cloudberry.apache.org)
- Discussions: https://github.com/apache/cloudberry/discussions -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix flaky regression and isolation2 tests [cloudberry]
Posted by "Alena0704 (via GitHub)" <gi...@apache.org>.
Alena0704 commented on PR #2133:
URL: https://github.com/apache/cloudberry/pull/2133#issuecomment-6409783732
Hi! Thank you for working on this. Can you split this commit by every test fixes - it is hard to review all in one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix flaky regression and isolation2 tests [cloudberry]
Posted by "Alena0704 (via GitHub)" <gi...@apache.org>.
Alena0704 commented on code in PR #2133:
URL: https://github.com/apache/cloudberry/pull/2133#discussion_r4398127953
##########
gpcontrib/gp_toolkit/gp_toolkit--1.0.sql:
##########
@@ -252,7 +252,7 @@ CREATE EXTERNAL WEB TABLE gp_toolkit.__gp_log_master_ext
logstack text
)
EXECUTE E'cat $GP_SEG_DATADIR/log/*.csv' ON COORDINATOR
-FORMAT 'CSV' (DELIMITER AS ',' NULL AS '' QUOTE AS '"');
+FORMAT 'CSV' (DELIMITER AS ',' NULL AS '' QUOTE AS '"' ESCAPE AS '\');
Review Comment:
Keep `FORMAT 'CSV' (DELIMITER AS ',' NULL AS '' QUOTE AS '"');`. Cloudberry’s CSV log writer escapes quotes by doubling them. Adding ESCAPE AS '\' mismatches that format: embedded quotes are lost, and fields ending in a backslash can fail with unterminated CSV quoted field.
##########
src/test/regress/sql/disable_autovacuum.sql:
##########
@@ -4,5 +4,7 @@ select gp_segment_id, pg_reload_conf() from gp_id union select gp_segment_id, pg
-- The reason for restarting cbdb here is that if the subsequent
-- vacuum ao test(uao*_catalog_tables/threshold) encounters an
-- unfinished transaction, it will fail.
+-- Use fast mode: smart mode would wait forever for this very session to
+-- disconnect, while this session is itself waiting for gpstop to return.
\!gpstop -ari
Review Comment:
You should replace it with `!\retcode gpstop -ari;`
\! is psql syntax. Isolation2 recognizes shell commands starting with ! and requires a terminating semicolon. The current line is silently discarded at EOF, so the restart never runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix flaky regression and isolation2 tests [cloudberry]
Posted by "chenjinbao1989 (via GitHub)" <gi...@apache.org>.
chenjinbao1989 commented on PR #2133:
URL: https://github.com/apache/cloudberry/pull/2133#issuecomment-6458843970
> Hi! Thank you for working on this. Can you split this commit by every test fixes - it is hard to review all in one.
Thank you very much.
There are quite a few files involved, but I'm not sure how to break these changes down into smaller, logical commits. Although many test files are affected, most of the failures are caused by the same underlying logic: once a certain condition is triggered, the mirror or standby attempts to catch up with the primary, but a failover/switchover occurs before the execution can complete.
I’ve left comments on every change. If anything is unclear, just let me know!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix flaky regression and isolation2 tests [cloudberry]
Posted by "Alena0704 (via GitHub)" <gi...@apache.org>.
Alena0704 commented on PR #2133:
URL: https://github.com/apache/cloudberry/pull/2133#issuecomment-6463771649
> > Hi! Thank you for working on this. Can you split this commit by every test fixes - it is hard to review all in one.
>
> Thank you very much.
>
> There are quite a few files involved, but I'm not sure how to break these changes down into smaller, logical commits. Although many test files are affected, most of the failures are caused by the same underlying logic: once a certain condition is triggered, the mirror or standby attempts to catch up with the primary, but a failover/switchover occurs before the execution can complete.
>
> I’ve left comments on every change. If anything is unclear, just let me know!
> > Hi! Thank you for working on this. Can you split this commit by every test fixes - it is hard to review all in one.
>
> Thank you very much.
>
> There are quite a few files involved, but I'm not sure how to break these changes down into smaller, logical commits. Although many test files are affected, most of the failures are caused by the same underlying logic: once a certain condition is triggered, the mirror or standby attempts to catch up with the primary, but a failover/switchover occurs before the execution can complete.
>
> I’ve left comments on every change. If anything is unclear, just let me know!
It is up to you, but you could split it into three commits:
1. Backend fix: remove the duplicate distribution-policy update in RemoveAttributeById(). Include a focused regression test if the invalidation scenario can be reproduced reliably. This deserves independent review and backporting.
2. gp_toolkit log parsing: keep this separate because it changes user-visible behavior. The current ESCAPE '\' change should be removed or reworked: it conflicts with the log writer’s doubled-quote format. Include a test that reads actual generated logs.
3. Test stabilization: group the remaining regression and isolation2 changes, including their PAX counterparts and expected outputs. Correct the isolation2 restart syntax first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix flaky regression and isolation2 tests [cloudberry]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe commented on PR #2133:
URL: https://github.com/apache/cloudberry/pull/2133#issuecomment-6407117429
Great! Thanks for your fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix flaky regression and isolation2 tests [cloudberry]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe commented on PR #2133:
URL: https://github.com/apache/cloudberry/pull/2133#issuecomment-6463486984
Reviewed by Claude Code through `ocr delegate` method and tested on a machine. FYI.
---
[pr2133-review-draft.md](https://github.com/user-attachments/files/34064530/pr2133-review-draft.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org