You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/09/14 15:08:56 UTC

[GitHub] [flink] syhily opened a new pull request #17283: [FLINK-24283][connector/pulsar] Use stick key consumer in Key_Shared subscription.

syhily opened a new pull request #17283:
URL: https://github.com/apache/flink/pull/17283


   ## What is the purpose of the change
   
   Use stick key consumer in Key_Shared subscription. This would make sure Pulsar won't treat the Flink reader as a shared consumer.
   
   This fix https://github.com/apache/pulsar/pull/12035
   
   ## Brief change log
   
     - Change consumer type in `PulsarSourceEnumerator`
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as `PulsarSourceKeySharedE2ECase` in [another PR](https://github.com/apache/flink/pull/17271).
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17283: [FLINK-24283][connector/pulsar] Use stick key consumer in Key_Shared subscription.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17283:
URL: https://github.com/apache/flink/pull/17283#issuecomment-919250975


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 9a64e19798b4baef7976b5ea0ea3da017a845d27 (Tue Sep 14 15:17:06 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] syhily commented on pull request #17283: [FLINK-24283][connector/pulsar] Use stick key consumer in Key_Shared subscription.

Posted by GitBox <gi...@apache.org>.
syhily commented on pull request #17283:
URL: https://github.com/apache/flink/pull/17283#issuecomment-919445827


   @fapaul Can you review this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17283: [FLINK-24283][connector/pulsar] Use stick key consumer in Key_Shared subscription.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17283:
URL: https://github.com/apache/flink/pull/17283#issuecomment-919276152


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9a64e19798b4baef7976b5ea0ea3da017a845d27",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24100",
       "triggerID" : "9a64e19798b4baef7976b5ea0ea3da017a845d27",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9a64e19798b4baef7976b5ea0ea3da017a845d27 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24100) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] syhily removed a comment on pull request #17283: [FLINK-24283][connector/pulsar] Use stick key consumer in Key_Shared subscription.

Posted by GitBox <gi...@apache.org>.
syhily removed a comment on pull request #17283:
URL: https://github.com/apache/flink/pull/17283#issuecomment-919445827


   @fapaul Can you review this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17283: [FLINK-24283][connector/pulsar] Use stick key consumer in Key_Shared subscription.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17283:
URL: https://github.com/apache/flink/pull/17283#issuecomment-919276152


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9a64e19798b4baef7976b5ea0ea3da017a845d27",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9a64e19798b4baef7976b5ea0ea3da017a845d27",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9a64e19798b4baef7976b5ea0ea3da017a845d27 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dawidwys merged pull request #17283: [FLINK-24283][connector/pulsar] Use stick key consumer in Key_Shared subscription.

Posted by GitBox <gi...@apache.org>.
dawidwys merged pull request #17283:
URL: https://github.com/apache/flink/pull/17283


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17283: [FLINK-24283][connector/pulsar] Use stick key consumer in Key_Shared subscription.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17283:
URL: https://github.com/apache/flink/pull/17283#issuecomment-919276152


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9a64e19798b4baef7976b5ea0ea3da017a845d27",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24100",
       "triggerID" : "9a64e19798b4baef7976b5ea0ea3da017a845d27",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9a64e19798b4baef7976b5ea0ea3da017a845d27 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24100) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dawidwys commented on pull request #17283: [FLINK-24283][connector/pulsar] Use stick key consumer in Key_Shared subscription.

Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #17283:
URL: https://github.com/apache/flink/pull/17283#issuecomment-919449494


   Yes, I will in a bit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org