You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "weishiuntsai (via GitHub)" <gi...@apache.org> on 2025/01/30 21:21:59 UTC
[PR] Migrate window function tests to quidem (druid)
weishiuntsai opened a new pull request, #17687:
URL: https://github.com/apache/druid/pull/17687
### Description
This PR migrated 34 sets of QA window function tests to quidem. These tests cover window functions in a more comprehensive way. Each test has a mixture of positive tests and negative tests. There are a total of 23072 queries in these tests. They use the existing kttm dataset.
This PR has:
- [X] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Add window function tests to quidem (druid)
Posted by "cryptoe (via GitHub)" <gi...@apache.org>.
cryptoe merged PR #17687:
URL: https://github.com/apache/druid/pull/17687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Add window function tests to quidem (druid)
Posted by "cryptoe (via GitHub)" <gi...@apache.org>.
cryptoe commented on PR #17687:
URL: https://github.com/apache/druid/pull/17687#issuecomment-2626262211
@weishiuntsai Could you please tell us how much does the pipeline runtime increase after these test cases get added ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Add window function tests to quidem (druid)
Posted by "weishiuntsai (via GitHub)" <gi...@apache.org>.
weishiuntsai commented on PR #17687:
URL: https://github.com/apache/druid/pull/17687#issuecomment-2626311954
On my MacBook, this particular set of tests ran for about 3 minutes. The total run time of `druid-quidem-ut` in the pipeline from this particular PR run was about 13 minutes.
```[INFO] druid-quidem-ut .................................... SUCCESS [13:26 min]```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org