[GitHub] [arrow] lidavidm commented on a diff in pull request #14506: ARROW-16673: [Java] WIP: proper handling of imported buffers

[GitBox <gi...@apache.org>]

lidavidm commented on code in PR #14506:
URL: https://github.com/apache/arrow/pull/14506#discussion_r1004954268


##########
java/c/src/main/java/org/apache/arrow/c/ArrayImporter.java:
##########
@@ -81,9 +84,7 @@ private void importChild(ArrayImporter parent, ArrowArray src) {
     recursionLevel = parent.recursionLevel + 1;
     checkState(recursionLevel <= MAX_IMPORT_RECURSION_LEVEL, "Recursion level in ArrowArray struct exceeded");
     // Child buffers will keep the entire parent import alive.
-    // Perhaps we can move the child structs on import,
-    // but that is another level of complication.

Review Comment:
   Not possible.
   
   > Consumers MUST call a base structure’s release callback when they won’t be using it anymore, but they MUST not call any of its children’s release callbacks (including the optional dictionary). The producer is responsible for releasing the children.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org