R: R: Abator factory extension - best practices

[Fabio Collini <fc...@omniagroup.it>]

Thank you for your reply.
 
 
We followed your suggestions regarding the
first two points. We didn't change the visibility of
the properties, they are all public like before.
 
A CommentGenerator interface is a great idea and it would be a very nice
feature in the direction of a even more extendibility.
 
Sorry for the delay of this answer....
bye and thank you
 
  _____  

OmniaSoftware ® s.r.l.
Fabio Collini 
(Analista Programmatore) 
Via Melloni, 29 - 50019 Sesto F.no (FI) 
Tel. 0554200158 
 <ma...@omniagroup.it> fcollini@omniagroup.it 
http://www.omniagroup.it/ 
  _____  


AVVISO DI RISERVATEZZA
Il testo e gli eventuali documenti trasmessi contengono informazioni
riservate al destinatario indicato. La seguente e-mail è confidenziale e la
sua riservatezza è tutelata legalmente dalle normative vigenti. La lettura,
copia od altro uso non autorizzato o qualsiasi altra azione derivante dalla
conoscenza di queste informazioni sono rigorosamente vietate. Se si ritiene
di non essere il destinatario di questa mail, o se si è ricevuto questa mail
per errore, si prega di darne immediata comunicazione al mittente e di
provvedere immediatamente alla sua distruzione. Le dichiarazioni contenute
nel presente messaggio, nonché nei suoi eventuali allegati, devono essere
attribuite esclusivamente al mittente e non possono essere considerate come
trasmesse o autorizzate da Omnia Software s.r.l.; le medesime dichiarazioni
non impegnano Omnia Software s.r.l. nei confronti del destinatario o di
terzi. Omnia Software s.r.l. non si assume alcuna responsabilità per
eventuali intercettazioni, modifiche o danneggiamenti del presente messaggio
e-mail.

PRIVACY NOTICE
The information contained in this transmittal, including any attachments
hereto, are confidential and privileged, and intended solely for the
specified addressee(s). This e-mail has a confidential nature which is
protected by the Italian law. Moreover, the recipient(s) may not disclose,
forward, or copy this e-mail or attachments, or any portion thereof, or
permit the use of this information, by anyone not entitled to it, or in a
way that may be damaging to the sender. If you are not the intended
addressee, or if you receive this message by error, please notify the sender
and delete this information from your computer. The statements and opinions
expressed in this e-mail message are those of the author of the message and
do not necessarily represent those of OMNIA SOFTWARE s.r.l. Besides, The
contents of this message shall be understood as neither given nor endorsed
by OMNIA SOFTWARE s.r.l.  OMNIA SOFTWARE s.r.l. does not accept liability
for corruption, interception or amendment, if any, or the consequences
thereof.

 

  _____  

Da: Jeff Butler [mailto:jeffgbutler@gmail.com] 
Inviato: martedì 28 agosto 2007 21.26
A: user-java@ibatis.apache.org
Oggetto: Re: R: Abator factory extension - best practices


Regarding protected get/set methods...this would be simple to implement on
your own.  Write a class that subclasses the appropriate JavaModelGenerator
you are using, override the "generateClassParts" method, and then specify
this class in the Abator configuration as the java model generator. 
 
If I were to implement this, I would likely do it as a property to the
JavaModelGenerator rather than a column by column override.  Seems to me
that most folks would want the visibility set the same for every member -
not needed on an individual basis.  Also, this wouldn't require any DTD
changes.  But, because these are not "real" domain objects, I think it's
kind of an unusual request.  Anyone else have comments about this? 
 
Regarding the custom comment request, I have heard this request before.
What if we did some kind of "CommentGenerator" interface that could be
plugged in?
 
Jeff Butler

 
On 8/28/07, Fabio Collini <fc...@omniagroup.it> wrote: 

Hello Jeff,
 
thank you for your reply. We're glad to hear that the way
you suggest of using Abator is quite similar to what we were
thinking about. The idea of having some factory came
out from the need to generate pojos with properties (get and set) protected.
 
We thought to achieve this with the following steps:
 
1) add a new attribute, visibility, to the xml element "columnoverride"
2) changing the DTD accordingly 
3) extend the class ColumnOverride to add the new property
4) extend the AbatorConfigurationParser to handle columnoverride.visibility
property
5) modify the bean generator to obtain bean with proptected getter/setter
 
It's difficult to obtain this because there are explicit costructor
invocation
of the parser and of the ColumnOverride (for example inside the method
AbatorConfigurationParser.parseColumnOverride). 
We thought that a factory for the parser and the ColumnOverride object would
solve this problem and make the design 
more extendible. What do you think?
 
Another question: is it possible to customize the behavior of the
bean/dao/sqlmap generators 
so that you can specify your own comment to be inserted? A setComment
method?
 
Thank you
Bye