You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@allura.apache.org by Igor Bondarenko <je...@gmail.com> on 2015/02/06 17:25:08 UTC
[allura:tickets] #7827 Upgrade jQuery to latest version
---
** [tickets:#7827] Upgrade jQuery to latest version**
**Status:** open
**Milestone:** unreleased
**Created:** Fri Feb 06, 2015 04:25 PM UTC by Igor Bondarenko
**Last Updated:** Fri Feb 06, 2015 04:25 PM UTC
**Owner:** nobody
See [#6297] for some thoughts and context
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] Re: #7827 Upgrade jQuery to latest version
Posted by Dave Brondsema <da...@brondsema.net>.
That overlay size is wrong because of a `login_fragment.html` template override for SourceForge only. If you set `disable_template_overrides = True` in your .ini file then it works fine (or uninstall ForgeSF and stop using any providers from it). So I think everything's ok in that regard.
---
** [tickets:#7827] Upgrade jQuery to latest version**
**Status:** review
**Milestone:** unreleased
**Labels:** 42cc sf-current sf-2
**Created:** Fri Feb 06, 2015 04:25 PM UTC by Igor Bondarenko
**Last Updated:** Tue Feb 24, 2015 02:44 PM UTC
**Owner:** Igor Bondarenko
See [#6297] for some thoughts and context
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7827 Upgrade jQuery to latest version
Posted by Igor Bondarenko <je...@gmail.com>.
Closed #734. Force-pushed `ib/7827` (rebase)
Take a look at login overlay at `/p/import_project/github/`. It doesn't show up right on my sandbox (see attachment), even on master and release versions. However it looks fine on forge-allura.apache.org which uses 1.2.1 release, so I assume it is something with my sandbox. I've tried allurasitetheme also, with the same result. sftheme looks fine, though.
Attachment: overlay.png (23.4 kB; image/png)
---
** [tickets:#7827] Upgrade jQuery to latest version**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** 42cc sf-current sf-2
**Created:** Fri Feb 06, 2015 04:25 PM UTC by Igor Bondarenko
**Last Updated:** Tue Feb 24, 2015 11:07 AM UTC
**Owner:** Igor Bondarenko
See [#6297] for some thoughts and context
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7827 Upgrade jQuery to latest version
Posted by Igor Bondarenko <je...@gmail.com>.
- **status**: in-progress --> review
- **Comment**:
Closed #722. `ib/7827`
Earlier version of `allura-base.js` have contained "tooltip" plugin. I see that it is used in two places in code (see below), but can't find it anywhere on UI, so I didn't include it for now. Maybe you know what it was used for and can point out it to me, so I can add it back and check that it still works?
~~~~~
Allura/allura/public/nf/js/allura-base.js
25: $this.tooltip({showURL: false});
Allura/allura/lib/widgets/project_list.py
98: $(badges[i]).parent('a[title]').tooltip({
~~~~~
**QA:**
Browse the site and watch for errors related to jQuery in the developer console.
You can also revert [02a539e] to be able to see jquery-migrate warnings, if any (ignore the `$.browser` one, since we have a piece of code for that).
Some areas to check:
- forms (especially ticket create/edit, since it has a lot of custom widgets)
- comments, replies
- admin UI (permissions, tools, etc)
- tracker field management
- ticket filters, milestones, etc
- whatever you may think of
Also, make sure it fixes [#6297] and close it too.
---
** [tickets:#7827] Upgrade jQuery to latest version**
**Status:** review
**Milestone:** unreleased
**Labels:** 42cc sf-current sf-2
**Created:** Fri Feb 06, 2015 04:25 PM UTC by Igor Bondarenko
**Last Updated:** Tue Feb 10, 2015 05:57 AM UTC
**Owner:** Igor Bondarenko
See [#6297] for some thoughts and context
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7827 Upgrade jQuery to latest version
Posted by Dave Brondsema <da...@brondsema.net>.
- **labels**: 42cc --> 42cc, sf-current
---
** [tickets:#7827] Upgrade jQuery to latest version**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** 42cc sf-current
**Created:** Fri Feb 06, 2015 04:25 PM UTC by Igor Bondarenko
**Last Updated:** Mon Feb 09, 2015 08:05 AM UTC
**Owner:** Igor Bondarenko
See [#6297] for some thoughts and context
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7827 Upgrade jQuery to latest version
Posted by Igor Bondarenko <je...@gmail.com>.
- **status**: in-progress --> review
---
** [tickets:#7827] Upgrade jQuery to latest version**
**Status:** review
**Milestone:** unreleased
**Labels:** 42cc sf-current sf-2
**Created:** Fri Feb 06, 2015 04:25 PM UTC by Igor Bondarenko
**Last Updated:** Tue Feb 24, 2015 11:52 AM UTC
**Owner:** Igor Bondarenko
See [#6297] for some thoughts and context
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7827 Upgrade jQuery to latest version
Posted by Igor Bondarenko <je...@gmail.com>.
- **labels**: --> 42cc
- **status**: open --> in-progress
- **assigned_to**: Igor Bondarenko
---
** [tickets:#7827] Upgrade jQuery to latest version**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** 42cc
**Created:** Fri Feb 06, 2015 04:25 PM UTC by Igor Bondarenko
**Last Updated:** Fri Feb 06, 2015 04:25 PM UTC
**Owner:** Igor Bondarenko
See [#6297] for some thoughts and context
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7827 Upgrade jQuery to latest version
Posted by Dave Brondsema <da...@brondsema.net>.
- **labels**: 42cc, sf-current --> 42cc, sf-current, sf-2
---
** [tickets:#7827] Upgrade jQuery to latest version**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** 42cc sf-current sf-2
**Created:** Fri Feb 06, 2015 04:25 PM UTC by Igor Bondarenko
**Last Updated:** Mon Feb 09, 2015 03:32 PM UTC
**Owner:** Igor Bondarenko
See [#6297] for some thoughts and context
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7827 Upgrade jQuery to latest version
Posted by Dave Brondsema <da...@brondsema.net>.
- **status**: review --> in-progress
- **Reviewer**: Dave Brondsema
- **Comment**:
jquery is missing altogether from /auth/ pages and /p/import_project pages. (TODO: test login overly on /p/import_project/google-code/ when jquery is there). Can cleanup the tooltip and badge stuff I mentioned above, as you see fit.
Created an internal SourceForge ticket for some changes needed there (#10191)
---
** [tickets:#7827] Upgrade jQuery to latest version**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** 42cc sf-current sf-2
**Created:** Fri Feb 06, 2015 04:25 PM UTC by Igor Bondarenko
**Last Updated:** Tue Feb 10, 2015 10:21 AM UTC
**Owner:** Igor Bondarenko
See [#6297] for some thoughts and context
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7827 Upgrade jQuery to latest version
Posted by Dave Brondsema <da...@brondsema.net>.
- **labels**: 42cc, sf-current, sf-2 --> 42cc, sf-2
---
** [tickets:#7827] Upgrade jQuery to latest version**
**Status:** closed
**Milestone:** unreleased
**Labels:** 42cc sf-2
**Created:** Fri Feb 06, 2015 04:25 PM UTC by Igor Bondarenko
**Last Updated:** Tue Feb 24, 2015 06:51 PM UTC
**Owner:** Igor Bondarenko
See [#6297] for some thoughts and context
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7827 Upgrade jQuery to latest version
Posted by Dave Brondsema <da...@brondsema.net>.
- **status**: review --> closed
---
** [tickets:#7827] Upgrade jQuery to latest version**
**Status:** closed
**Milestone:** unreleased
**Labels:** 42cc sf-current sf-2
**Created:** Fri Feb 06, 2015 04:25 PM UTC by Igor Bondarenko
**Last Updated:** Tue Feb 24, 2015 02:44 PM UTC
**Owner:** Igor Bondarenko
See [#6297] for some thoughts and context
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] Re: #7827 Upgrade jQuery to latest version
Posted by Dave Brondsema <da...@brondsema.net>.
I think the tooltip stuff can go.
The first reference you gave doesn't match on anything in our current templates I don't think. I traced it back to commit [d36ab9], before we were even using jinja. I don't think that HTML structure was kept.
The second reference can come through via the `[[projects]]` macro, but I believe the js is not used. `<small class="badge">` was removed in [ed2751]
BTW, I'm making some small adjustments in sftheme to support the jquery upgrade.
---
** [tickets:#7827] Upgrade jQuery to latest version**
**Status:** review
**Milestone:** unreleased
**Labels:** 42cc sf-current sf-2
**Created:** Fri Feb 06, 2015 04:25 PM UTC by Igor Bondarenko
**Last Updated:** Tue Feb 10, 2015 10:21 AM UTC
**Owner:** Igor Bondarenko
See [#6297] for some thoughts and context
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.