You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by phrocker <gi...@git.apache.org> on 2017/09/25 15:30:36 UTC
[GitHub] nifi-minifi-cpp pull request #138: MINIFICPP-109: Add header guards for cive...
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/138
MINIFICPP-109: Add header guards for civetweb so users who don't have…
… pragma defs can build
Extracted from https://github.com/KevinCalderone/civetweb/commit/1b25c739802bac622edc83f9ca9f0f9e695879a4
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-109
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/138.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #138
----
commit ff6f3ff4e6da43b9f5645d91765f93aba502a15e
Author: Marc Parisi <ph...@apache.org>
Date: 2017-09-25T15:29:03Z
MINIFICPP-109: Add header guards for civetweb so users who don't have pragma defs can build.
Pulled from merged PR located at :
https://github.com/KevinCalderone/civetweb/commit/1b25c739802bac622edc83f9ca9f0f9e695879a4
----
---
[GitHub] nifi-minifi-cpp issue #138: MINIFICPP-109: Add header guards for civetweb so...
Posted by achristianson <gi...@git.apache.org>.
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/138
lgtm
---
[GitHub] nifi-minifi-cpp issue #138: MINIFICPP-109: Add header guards for civetweb so...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/138
Looks good. Will merge.
---
[GitHub] nifi-minifi-cpp pull request #138: MINIFICPP-109: Add header guards for cive...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/138
---