You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Anthony Baker <ab...@apache.org> on 2016/03/23 04:16:23 UTC
Review Request 45196: GEODE-857: Fix data race in SystemFailureJUnit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45196/
-----------------------------------------------------------
Review request for geode and Dan Smith.
Repository: geode
Description
-------
The SystemFailure class was storing state in a static var without
ensuring thread-safe reads and writes. This was causing intermittent
test failures. Fixed the data race and set the flag correctly as a
test precondition.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/SystemFailure.java 1775063921493c85e19d0138faea3383aea1496d
geode-core/src/test/java/com/gemstone/gemfire/SystemFailureJUnitTest.java c5efaf01e8bb22526189a0ed8ff5d378e69c7e93
Diff: https://reviews.apache.org/r/45196/diff/
Testing
-------
Thanks,
Anthony Baker
Re: Review Request 45196: GEODE-857: Fix data race in
SystemFailureJUnit
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45196/#review125052
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On March 23, 2016, 3:16 a.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45196/
> -----------------------------------------------------------
>
> (Updated March 23, 2016, 3:16 a.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The SystemFailure class was storing state in a static var without
> ensuring thread-safe reads and writes. This was causing intermittent
> test failures. Fixed the data race and set the flag correctly as a
> test precondition.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/SystemFailure.java 1775063921493c85e19d0138faea3383aea1496d
> geode-core/src/test/java/com/gemstone/gemfire/SystemFailureJUnitTest.java c5efaf01e8bb22526189a0ed8ff5d378e69c7e93
>
> Diff: https://reviews.apache.org/r/45196/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 45196: GEODE-857: Fix data race in
SystemFailureJUnit
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45196/#review124957
-----------------------------------------------------------
Ship it!
Ship It!
- Kirk Lund
On March 23, 2016, 3:16 a.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45196/
> -----------------------------------------------------------
>
> (Updated March 23, 2016, 3:16 a.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The SystemFailure class was storing state in a static var without
> ensuring thread-safe reads and writes. This was causing intermittent
> test failures. Fixed the data race and set the flag correctly as a
> test precondition.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/SystemFailure.java 1775063921493c85e19d0138faea3383aea1496d
> geode-core/src/test/java/com/gemstone/gemfire/SystemFailureJUnitTest.java c5efaf01e8bb22526189a0ed8ff5d378e69c7e93
>
> Diff: https://reviews.apache.org/r/45196/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>